1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

events: remove unreachable code

Browse Source 
Commit 8d386ed7e1301c869bbc266ce73650b280c9ae26 stopped the
Event Emitter implementation from storing arrays containing a
single listener. This change left a section of code in
removeListener() as unreachable. This commit removes the
unreachable code.

Refs: https://github.com/nodejs/node/pull/12043
PR-URL: https://github.com/nodejs/node/pull/12501
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
cjihrig 2017-04-18 21:01:48 -04:00
parent 1159a717fc
commit 58066d16d5
1 changed files with 5 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
lib/events.js
View File

@ -374,22 +374,13 @@ EventEmitter.prototype.removeListener =
if (position < 0)
return this;
if (list.length === 1) {
if (--this._eventsCount === 0) {
this._events = Object.create(null);
return this;
} else {
delete events[type];
}
} else if (position === 0) {
if (position === 0)
list.shift();
if (list.length === 1)
events[type] = list[0];
} else {
else
spliceOne(list, position);
if (list.length === 1)
events[type] = list[0];
}
if (list.length === 1)
events[type] = list[0];
if (events.removeListener)
this.emit('removeListener', type, originalListener || listener);