1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

lib: reduce url getters on makeRequireFunction

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/48492
Refs: https://github.com/nodejs/performance/issues/92
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Yagiz Nizipli 2023-06-23 20:33:22 -04:00 committed by GitHub
parent 9b61322e02
commit 578ffe1edb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/internal/modules/helpers.js
View File

@ -86,8 +86,8 @@ function makeRequireFunction(mod, redirects) {
if (destination === true) { if (destination === true) {
missing = false; missing = false;
} else if (destination) { } else if (destination) {
const href = destination.href; const { href, protocol } = destination;
if (destination.protocol === 'node:') { if (protocol === 'node:') {
const specifier = destination.pathname; const specifier = destination.pathname;
if (BuiltinModule.canBeRequiredByUsers(specifier)) { if (BuiltinModule.canBeRequiredByUsers(specifier)) {
@ -95,11 +95,9 @@ function makeRequireFunction(mod, redirects) {
return mod.exports; return mod.exports;
} }
throw new ERR_UNKNOWN_BUILTIN_MODULE(specifier); throw new ERR_UNKNOWN_BUILTIN_MODULE(specifier);
} else if (destination.protocol === 'file:') { } else if (protocol === 'file:') {
let filepath; let filepath = urlToFileCache.get(href);
if (urlToFileCache.has(href)) { if (!filepath) {
filepath = urlToFileCache.get(href);
} else {
filepath = fileURLToPath(destination); filepath = fileURLToPath(destination);
urlToFileCache.set(href, filepath); urlToFileCache.set(href, filepath);
} }