1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: use really invalid hostname

Browse Source 
On my slow Ubuntu 14.04 machine, this fails to resolve the host name
used (`no.way.you.will.resolve.this`) and it times out in local testing.
This patch uses an invalid name (`...`) and does stricter validation of
the error returned.

PR-URL: https://github.com/nodejs/node/pull/3711
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Sakthipriyan Vairamani 2015-11-08 16:31:51 +05:30 committed by James M Snell
parent 20285ad177
commit 570725840c
1 changed files with 12 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
test/parallel/test-net-connect-immediate-finish.js
View File

@ -1,21 +1,17 @@
'use strict';
var common = require('../common');
var assert = require('assert');
var net = require('net');
const common = require('../common');
const assert = require('assert');
const net = require('net');
var gotError = false;
const client = net.connect({host: '...', port: common.PORT});
var client = net.connect({
host: 'no.way.you.will.resolve.this',
port: common.PORT
});
client.once('error', function(err) {
gotError = true;
});
client.once('error', common.mustCall(function(err) {
assert(err);
assert.strictEqual(err.code, err.errno);
assert.strictEqual(err.code, 'ENOTFOUND');
assert.strictEqual(err.host, err.hostname);
assert.strictEqual(err.host, '...');
assert.strictEqual(err.syscall, 'getaddrinfo');
}));
client.end();
process.on('exit', function() {
assert(gotError);
});