1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

child_process: make process_wrap binding internal

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/22479
Refs: https://github.com/nodejs/node/issues/22160
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
cjihrig 2018-08-23 11:04:19 -04:00
parent 68dff4a67b
commit 56cf058878
No known key found for this signature in database
GPG Key ID: 7434390BDBE9B9C5
5 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/internal/bootstrap/node.js
View File

@ -350,6 +350,7 @@
new SafeSet([ new SafeSet([
'uv', 'uv',
'http_parser', 'http_parser',
'process_wrap',
'v8', 'v8',
'stream_wrap', 'stream_wrap',
'signal_wrap', 'signal_wrap',

2
lib/internal/child_process.js
View File

@ -23,7 +23,7 @@ const assert = require('assert');
const { internalBinding } = require('internal/bootstrap/loaders'); const { internalBinding } = require('internal/bootstrap/loaders');
const { Process } = process.binding('process_wrap'); const { Process } = internalBinding('process_wrap');
const { WriteWrap } = internalBinding('stream_wrap'); const { WriteWrap } = internalBinding('stream_wrap');
const { Pipe, constants: PipeConstants } = process.binding('pipe_wrap'); const { Pipe, constants: PipeConstants } = process.binding('pipe_wrap');
const { TTY } = process.binding('tty_wrap'); const { TTY } = process.binding('tty_wrap');

2
src/process_wrap.cc
View File

@ -315,4 +315,4 @@ class ProcessWrap : public HandleWrap {
} // anonymous namespace } // anonymous namespace
} // namespace node } // namespace node
NODE_BUILTIN_MODULE_CONTEXT_AWARE(process_wrap, node::ProcessWrap::Initialize) NODE_MODULE_CONTEXT_AWARE_INTERNAL(process_wrap, node::ProcessWrap::Initialize)

4
test/parallel/test-process-wrap.js
View File

@ -1,3 +1,4 @@
// Flags: --expose-internals
// Copyright Joyent, Inc. and other Node contributors. // Copyright Joyent, Inc. and other Node contributors.
// //
// Permission is hereby granted, free of charge, to any person obtaining a // Permission is hereby granted, free of charge, to any person obtaining a
@ -22,7 +23,8 @@
'use strict'; 'use strict';
require('../common'); require('../common');
const assert = require('assert'); const assert = require('assert');
const Process = process.binding('process_wrap').Process; const { internalBinding } = require('internal/test/binding');
const Process = internalBinding('process_wrap').Process;
const { Pipe, constants: PipeConstants } = process.binding('pipe_wrap'); const { Pipe, constants: PipeConstants } = process.binding('pipe_wrap');
const pipe = new Pipe(PipeConstants.SOCKET); const pipe = new Pipe(PipeConstants.SOCKET);
const p = new Process(); const p = new Process();

2
test/sequential/test-async-wrap-getasyncid.js
View File

@ -182,7 +182,7 @@ if (common.hasCrypto) { // eslint-disable-line node-core/crypto-check
} }
{ {
const Process = process.binding('process_wrap').Process; const Process = internalBinding('process_wrap').Process;
testInitialized(new Process(), 'Process'); testInitialized(new Process(), 'Process');
} }