1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix flaky test-cluster-dgram-2

Browse Source 
There is no guarantee that a dgram packet will be received. The test is
currently written to only send exactly as many dgram packets as required
assuming they are all received. As a result, failures like this may
occur (from CI):

```
not ok 719 parallel/test-cluster-dgram-2
  ---
  duration_ms: 120.39
  severity: fail
  stack: |-
    timeout
```

This change has the workers send packets continuously until disconnect.

PR-URL: https://github.com/nodejs/node/pull/9791
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
This commit is contained in:
Rich Trott 2016-11-24 15:04:14 -08:00
parent 566a1513d1
commit 56ca9cd1ba
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
test/parallel/test-cluster-dgram-2.js
View File

@ -57,6 +57,13 @@ function worker() {
// send(), explicitly bind them to an ephemeral port. // send(), explicitly bind them to an ephemeral port.
socket.bind(0); socket.bind(0);
for (var i = 0; i < PACKETS_PER_WORKER; i++) // There is no guarantee that a sent dgram packet will be received so keep
// sending until disconnect.
const interval = setInterval(() => {
socket.send(buf, 0, buf.length, common.PORT, '127.0.0.1'); socket.send(buf, 0, buf.length, common.PORT, '127.0.0.1');
}, 1);
cluster.worker.on('disconnect', () => {
clearInterval(interval);
});
} }