1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: switch actual value argument and expected in deepStrictEqual call

Browse Source 
Replace deepStrictEqual call to have actual value as the first argument
and the expected value as the second.

Change expectedRecvData definition in single place.

PR-URL: https://github.com/nodejs/node/pull/27888
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
This commit is contained in:
Kopachyov Vitaliy 2019-05-26 14:13:58 +03:00 committed by Сковорода Никита Андреевич
parent 2e9cd82325
commit 55de6ff38d
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
test/parallel/test-http-upgrade-client.js
View File

@ -31,6 +31,8 @@ const http = require('http');
const net = require('net');
const Countdown = require('../common/countdown');
const expectedRecvData = 'nurtzo';
// Create a TCP server
const srv = net.createServer(function(c) {
c.on('data', function(d) {
@ -39,7 +41,7 @@ const srv = net.createServer(function(c) {
c.write('connection: upgrade\r\n');
c.write('upgrade: websocket\r\n');
c.write('\r\n');
c.write('nurtzo');
c.write(expectedRecvData);
});
c.on('end', function() {
@ -77,7 +79,7 @@ srv.listen(0, '127.0.0.1', common.mustCall(function() {
});
socket.on('close', common.mustCall(function() {
assert.strictEqual(recvData.toString(), 'nurtzo');
assert.strictEqual(recvData.toString(), expectedRecvData);
}));
console.log(res.headers);
@ -86,8 +88,7 @@ srv.listen(0, '127.0.0.1', common.mustCall(function() {
connection: 'upgrade',
upgrade: 'websocket'
};
assert.deepStrictEqual(expectedHeaders, res.headers);
assert.deepStrictEqual(res.headers, expectedHeaders);
socket.end();
countdown.dec();
}));