1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

build: warn for gcc versions earlier than 8.3.0

Browse Source 
Update the warning threshold to match the minimum supported version
of gcc. Builds can still proceed, but are not guaranteed to work.

PR-URL: https://github.com/nodejs/node/pull/37935
Refs: https://github.com/nodejs/node/pull/37871
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Richard Lau 2021-03-26 15:18:07 -04:00 committed by Antoine du Hamel
parent 19ed27d61f
commit 558d1e6c22
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
configure.py
View File

@ -960,8 +960,8 @@ def check_compiler(o):
('clang ' if is_clang else '', CXX, version_str))
if not ok:
warn('failed to autodetect C++ compiler version (CXX=%s)' % CXX)
elif clang_version < (8, 0, 0) if is_clang else gcc_version < (6, 3, 0):
warn('C++ compiler (CXX=%s, %s) too old, need g++ 6.3.0 or clang++ 8.0.0' %
elif clang_version < (8, 0, 0) if is_clang else gcc_version < (8, 3, 0):
warn('C++ compiler (CXX=%s, %s) too old, need g++ 8.3.0 or clang++ 8.0.0' %
(CXX, version_str))
ok, is_clang, clang_version, gcc_version = try_check_compiler(CC, 'c')