1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fs: remove experimental warning for fs.promises

Browse Source 
This has been warning for long enough, without any API changes
in the last few months.

PR-URL: https://github.com/nodejs/node/pull/26581
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Anna Henningsen 2019-03-11 10:19:47 +00:00
parent 82bf240eba
commit 5583d4d73e
No known key found for this signature in database
GPG Key ID: 9C63F3A6CD2AD8F9
3 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
doc/api/fs.md
View File

@ -3699,7 +3699,7 @@ this API: [`fs.write(fd, string...)`][].
## fs Promises API ## fs Promises API
> Stability: 1 - Experimental > Stability: 2 - Stable
The `fs.promises` API provides an alternative set of asynchronous file system The `fs.promises` API provides an alternative set of asynchronous file system
methods that return `Promise` objects rather than using callbacks. The methods that return `Promise` objects rather than using callbacks. The

7
lib/fs.js
View File

@ -1930,13 +1930,10 @@ Object.defineProperties(fs, {
}, },
promises: { promises: {
configurable: true, configurable: true,
enumerable: false, enumerable: true,
get() { get() {
if (promises === null) { if (promises === null)
promises = require('internal/fs/promises'); promises = require('internal/fs/promises');
process.emitWarning('The fs.promises API is experimental',
'ExperimentalWarning');
}
return promises; return promises;
} }
} }

5
test/parallel/test-fs-promises.js
View File

@ -40,9 +40,8 @@ function nextdir() {
return `test${++dirc}`; return `test${++dirc}`;
} }
// fs.promises should not be enumerable as long as it causes a warning to be // fs.promises should not enumerable.
// emitted. assert.strictEqual(Object.keys(fs).includes('promises'), true);
assert.strictEqual(Object.keys(fs).includes('promises'), false);
{ {
access(__filename, 'r') access(__filename, 'r')