doc: revise Collaborator material in GOVERNANCE.md

* Reduce passive voice
* Shorter and simpler sentences

PR-URL: https://github.com/nodejs/node/pull/27103
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
This commit is contained in:
Rich Trott 2019-04-05 11:26:37 -07:00
parent 1afec97130
commit 557bd861aa

View File

@ -21,26 +21,21 @@ privileges include but are not limited to:
* Commit access to the [nodejs/node][] repository * Commit access to the [nodejs/node][] repository
* Access to the Node.js continuous integration (CI) jobs * Access to the Node.js continuous integration (CI) jobs
Modifications of the contents of the nodejs/node repository are made on Both Collaborators and non-Collaborators may propose changes to the Node.js
a collaborative basis. Anybody with a GitHub account may propose a source code. The mechanism to propose such a change is a GitHub pull request.
modification via pull request and it will be considered by the project Collaborators are responsible for reviewing and merging (_landing_)
Collaborators. pull requests.
At least two Collaborators must approve a pull request before the pull request At least two Collaborators must approve a pull request before the pull request
lands. (One Collaborator approval is enough if the pull request has been open can land. (One Collaborator approval is enough if the pull request has been open
for more than 7 days.) Approving a pull request indicates that the Collaborator for more than 7 days.) Approving a pull request indicates that the Collaborator
accepts responsibility for the change. Approval must be from Collaborators who accepts responsibility for the change. Approval must be from Collaborators who
are not authors of the change. are not authors of the change.
If one or more Collaborators oppose a proposed change, then the change cannot If a Collaborator opposes a proposed change, then the change cannot land. The
be accepted unless: exception is if the TSC votes to approve the change despite the opposition.
Usually, involving the TSC is unnecessary. Often, discussions or further changes
* Discussions and/or additional changes result in no Collaborators objecting to result in Collaborators removing their opposition.
the change. Previously-objecting Collaborators do not necessarily have to
sign off on the change, but they should not be opposed to it.
* The change is escalated to the TSC and the TSC votes to approve the change.
This should only happen if disagreements between Collaborators cannot be
resolved through discussion.
See: See: