1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

events: optimize listener array cloning

Browse Source 
This both switches to a single algorithm for array cloning and also
speeds up (by ~100% in the ee-listeners-many benchmark) the
"many elements"  case that was previously handled by
`array.slice()`.

PR-URL: https://github.com/iojs/io.js/pull/1050
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Julian Duque <julianduquej@gmail.com>
This commit is contained in:
Brian White 2015-03-04 22:21:47 -05:00
parent 563771d8b1
commit 555a7c48cf
1 changed files with 6 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
lib/events.js
View File

@ -384,7 +384,7 @@ EventEmitter.prototype.listeners = function listeners(type) {
else if (typeof evlistener === 'function') else if (typeof evlistener === 'function')
ret = [evlistener]; ret = [evlistener];
else else
ret = arrayClone(evlistener); ret = arrayClone(evlistener, evlistener.length);
} }
return ret; return ret;
@ -413,16 +413,9 @@ function spliceOne(list, index) {
list.pop(); list.pop();
} }
function arrayClone(arr, len) { function arrayClone(arr, i) {
var ret; var copy = new Array(i);
if (len === undefined) while (i--)
len = arr.length; copy[i] = arr[i];
if (len >= 50) return copy;
ret = arr.slice();
else {
ret = new Array(len);
for (var i = 0; i < len; i += 1)
ret[i] = arr[i];
}
return ret;
} }