1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

http: remove duplicate parser unset

Browse Source 
freeParser already unsets parser property of socket if socket is passed
in specifically. There's no need to do this twice.

PR-URL: https://github.com/nodejs/node/pull/20126
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This commit is contained in:
Anatoli Papirovski 2018-04-18 10:20:13 +02:00 committed by Ruben Bridgewater
parent 58e0800b81
commit 54e112dd61
No known key found for this signature in database
GPG Key ID: F07496B3EB3C1762
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/_http_common.js
View File

@ -191,8 +191,6 @@ function freeParser(parser, req, socket) {
if (parser._consumed) if (parser._consumed)
parser.unconsume(); parser.unconsume();
parser._consumed = false; parser._consumed = false;
if (parser.socket)
parser.socket.parser = null;
parser.socket = null; parser.socket = null;
parser.incoming = null; parser.incoming = null;
parser.outgoing = null; parser.outgoing = null;

2
lib/_http_server.js
View File

@ -522,7 +522,7 @@ function onParserExecuteCommon(server, socket, parser, state, ret, d) {
socket.removeListener('error', socketOnError); socket.removeListener('error', socketOnError);
unconsume(parser, socket); unconsume(parser, socket);
parser.finish(); parser.finish();
freeParser(parser, req, null); freeParser(parser, req, socket);
parser = null; parser = null;
var eventName = req.method === 'CONNECT' ? 'connect' : 'upgrade'; var eventName = req.method === 'CONNECT' ? 'connect' : 'upgrade';