1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

build: do not indent assignments in Makefile

Browse Source 
Indented assignment in a Makefile can be interpreted
as a command in e.g. GNU Make 3.81 which results in the
following error:

```
make: CPPLINT_QUIET: No such file or directory
```

PR-URL: https://github.com/nodejs/node/pull/29623
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This commit is contained in:
Joyee Cheung 2019-09-20 10:42:37 +09:00 committed by Rich Trott
parent aa32e13968
commit 54a0553a9f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Makefile
View File

@ -1312,9 +1312,9 @@ else
endif endif
ifeq ($(V),1) ifeq ($(V),1)
CPPLINT_QUIET = CPPLINT_QUIET =
else else
CPPLINT_QUIET = --quiet CPPLINT_QUIET = --quiet
endif endif
.PHONY: lint-cpp .PHONY: lint-cpp
# Lints the C++ code with cpplint.py and check-imports.py. # Lints the C++ code with cpplint.py and check-imports.py.