1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix a TODO and remove obsolete TODOs

Browse Source 
This removes outdated TODOs and adds a test for invalid input in
`fs.copyFile` and solves a TODO by doing so.

PR-URL: https://github.com/nodejs/node/pull/20319
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Ruben Bridgewater 2018-04-26 05:44:14 +02:00
parent 29cddb40b2
commit 541d2192cf
No known key found for this signature in database
GPG Key ID: F07496B3EB3C1762
4 changed files with 11 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/url.js
View File

@ -281,9 +281,6 @@ Url.prototype.parse = function parse(url, parseQueryString, slashesDenoteHost) {
// http://a@b@c/ => user:a@b host:c // http://a@b@c/ => user:a@b host:c
// http://a@b?@c => user:a host:b path:/?@c // http://a@b?@c => user:a host:b path:/?@c
// v0.12 TODO(isaacs): This is not quite how Chrome does things.
// Review our test case against browsers more comprehensively.
var hostEnd = -1; var hostEnd = -1;
var atSign = -1; var atSign = -1;
var nonHost = -1; var nonHost = -1;

1
test/parallel/test-cluster-http-pipe.js
View File

@ -45,7 +45,6 @@ if (cluster.isMaster) {
http.createServer(common.mustCall((req, res) => { http.createServer(common.mustCall((req, res) => {
assert.strictEqual(req.connection.remoteAddress, undefined); assert.strictEqual(req.connection.remoteAddress, undefined);
assert.strictEqual(req.connection.localAddress, undefined); assert.strictEqual(req.connection.localAddress, undefined);
// TODO common.PIPE?
res.writeHead(200); res.writeHead(200);
res.end('OK'); res.end('OK');

23
test/parallel/test-fs-error-messages.js
View File

@ -636,22 +636,21 @@ if (!common.isAIX) {
); );
} }
// copyFile with invalid flags // Check copyFile with invalid flags.
{ {
const validateError = (err) => { const validateError = {
assert.strictEqual(err.message, // TODO: Make sure the error message always also contains the src.
'EINVAL: invalid argument, copyfile ' + message: `EINVAL: invalid argument, copyfile -> '${nonexistentFile}'`,
`'${existingFile}' -> '${nonexistentFile}'`); errno: uv.UV_EINVAL,
assert.strictEqual(err.errno, uv.UV_EINVAL); code: 'EINVAL',
assert.strictEqual(err.code, 'EINVAL'); syscall: 'copyfile'
assert.strictEqual(err.syscall, 'copyfile');
return true;
}; };
// TODO(joyeecheung): test fs.copyFile() when uv_fs_copyfile does not fs.copyFile(existingFile, nonexistentFile, -1,
// keep the loop open when the flags are invalid. common.expectsError(validateError));
// See https://github.com/libuv/libuv/pull/1747
validateError.message = 'EINVAL: invalid argument, copyfile ' +
`'${existingFile}' -> '${nonexistentFile}'`;
assert.throws( assert.throws(
() => fs.copyFileSync(existingFile, nonexistentFile, -1), () => fs.copyFileSync(existingFile, nonexistentFile, -1),
validateError validateError

2
test/parallel/test-util-isDeepStrictEqual.js
View File

@ -419,8 +419,6 @@ notUtilIsDeepStrict([1, , , 3], [1, , , 3, , , ]);
const err3 = new TypeError('foo1'); const err3 = new TypeError('foo1');
notUtilIsDeepStrict(err1, err2, assert.AssertionError); notUtilIsDeepStrict(err1, err2, assert.AssertionError);
notUtilIsDeepStrict(err1, err3, assert.AssertionError); notUtilIsDeepStrict(err1, err3, assert.AssertionError);
// TODO: evaluate if this should throw or not. The same applies for RegExp
// Date and any object that has the same keys but not the same prototype.
notUtilIsDeepStrict(err1, {}, assert.AssertionError); notUtilIsDeepStrict(err1, {}, assert.AssertionError);
} }