From 53a5d87becb664c183d63a5c028641bc248f0771 Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Tue, 20 Feb 2018 05:41:28 +0100 Subject: [PATCH] test: fix deprecation warning in binding.cc Currently, the make-callback-domain-warning addon generates the following warning: ../binding.cc:22:9: warning: 'MakeCallback' is deprecated: Use MakeCallback(..., async_context) [-Wdeprecated-declarations] node::MakeCallback(isolate, recv, method, 0, nullptr); ^ ../../../../src/node.h:172:50: note: 'MakeCallback' has been explicitly marked deprecated here NODE_EXTERN v8::Local MakeCallback( ^ 1 warning generated. This commit fixes this warning. PR-URL: https://github.com/nodejs/node/pull/18877 Reviewed-By: Ali Ijaz Sheikh --- test/addons/make-callback-domain-warning/binding.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/addons/make-callback-domain-warning/binding.cc b/test/addons/make-callback-domain-warning/binding.cc index c42166c7455..d02c8f51766 100644 --- a/test/addons/make-callback-domain-warning/binding.cc +++ b/test/addons/make-callback-domain-warning/binding.cc @@ -19,7 +19,8 @@ void MakeCallback(const FunctionCallbackInfo& args) { Local recv = args[0].As(); Local method = args[1].As(); - node::MakeCallback(isolate, recv, method, 0, nullptr); + node::MakeCallback(isolate, recv, method, 0, nullptr, + node::async_context{0, 0}); } void Initialize(Local exports) {