test: extended test to makeCallback cb type check
makeCallback and makeStatsCallback are both tested intedependently. PR-URL: https://github.com/nodejs/node/pull/12140 Fixes: https://github.com/nodejs/node/issues/12136 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This commit is contained in:
parent
7eb1b4658e
commit
53828e8bff
@ -3,37 +3,29 @@ const common = require('../common');
|
||||
const assert = require('assert');
|
||||
const fs = require('fs');
|
||||
const cbTypeError = /^TypeError: "callback" argument must be a function$/;
|
||||
const callbackThrowValues = [null, true, false, 0, 1, 'foo', /foo/, [], {}];
|
||||
|
||||
function test(cb) {
|
||||
const { sep } = require('path');
|
||||
const warn = 'Calling an asynchronous function without callback is deprecated.';
|
||||
|
||||
common.refreshTmpDir();
|
||||
|
||||
function testMakeCallback(cb) {
|
||||
return function() {
|
||||
// fs.stat() calls makeCallback() on its second argument
|
||||
fs.stat(__filename, cb);
|
||||
// fs.mkdtemp() calls makeCallback() on its third argument
|
||||
fs.mkdtemp(`${common.tmpDir}${sep}`, {}, cb);
|
||||
};
|
||||
}
|
||||
|
||||
// Verify the case where a callback function is provided
|
||||
assert.doesNotThrow(test(common.noop));
|
||||
|
||||
process.once('warning', common.mustCall((warning) => {
|
||||
assert.strictEqual(
|
||||
warning.message,
|
||||
'Calling an asynchronous function without callback is deprecated.'
|
||||
);
|
||||
|
||||
invalidArgumentsTests();
|
||||
}));
|
||||
common.expectWarning('DeprecationWarning', warn);
|
||||
|
||||
// Passing undefined/nothing calls rethrow() internally, which emits a warning
|
||||
assert.doesNotThrow(test());
|
||||
assert.doesNotThrow(testMakeCallback());
|
||||
|
||||
function invalidArgumentsTests() {
|
||||
assert.throws(test(null), cbTypeError);
|
||||
assert.throws(test(true), cbTypeError);
|
||||
assert.throws(test(false), cbTypeError);
|
||||
assert.throws(test(1), cbTypeError);
|
||||
assert.throws(test(0), cbTypeError);
|
||||
assert.throws(test('foo'), cbTypeError);
|
||||
assert.throws(test(/foo/), cbTypeError);
|
||||
assert.throws(test([]), cbTypeError);
|
||||
assert.throws(test({}), cbTypeError);
|
||||
function invalidCallbackThrowsTests() {
|
||||
callbackThrowValues.forEach((value) => {
|
||||
assert.throws(testMakeCallback(value), cbTypeError);
|
||||
});
|
||||
}
|
||||
|
||||
invalidCallbackThrowsTests();
|
||||
|
30
test/parallel/test-fs-makeStatsCallback.js
Normal file
30
test/parallel/test-fs-makeStatsCallback.js
Normal file
@ -0,0 +1,30 @@
|
||||
'use strict';
|
||||
const common = require('../common');
|
||||
const assert = require('assert');
|
||||
const fs = require('fs');
|
||||
const cbTypeError = /^TypeError: "callback" argument must be a function$/;
|
||||
const callbackThrowValues = [null, true, false, 0, 1, 'foo', /foo/, [], {}];
|
||||
const warn = 'Calling an asynchronous function without callback is deprecated.';
|
||||
|
||||
function testMakeStatsCallback(cb) {
|
||||
return function() {
|
||||
// fs.stat() calls makeStatsCallback() on its second argument
|
||||
fs.stat(__filename, cb);
|
||||
};
|
||||
}
|
||||
|
||||
common.expectWarning('DeprecationWarning', warn);
|
||||
|
||||
// Verify the case where a callback function is provided
|
||||
assert.doesNotThrow(testMakeStatsCallback(common.noop));
|
||||
|
||||
// Passing undefined/nothing calls rethrow() internally, which emits a warning
|
||||
assert.doesNotThrow(testMakeStatsCallback());
|
||||
|
||||
function invalidCallbackThrowsTests() {
|
||||
callbackThrowValues.forEach((value) => {
|
||||
assert.throws(testMakeStatsCallback(value), cbTypeError);
|
||||
});
|
||||
}
|
||||
|
||||
invalidCallbackThrowsTests();
|
Loading…
x
Reference in New Issue
Block a user