1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

build: remove unused label from vcbuild.bat

Browse Source 
Remove the :wix-not-found label and harmonize the spelling of "WiX".

PR-URL: https://github.com/nodejs/node/pull/26901
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This commit is contained in:
Ben Noordhuis 2019-03-25 11:43:21 +01:00 committed by Michaël Zasso
parent a3cf96c76f
commit 534d0dc5a8
No known key found for this signature in database
GPG Key ID: 770F7A9A5AE15600
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
vcbuild.bat
View File

@ -239,7 +239,7 @@ if defined msi (
goto msbuild-not-found goto msbuild-not-found
) )
if not exist "%VCINSTALLDIR%\..\MSBuild\Microsoft\WiX" ( if not exist "%VCINSTALLDIR%\..\MSBuild\Microsoft\WiX" (
echo Failed to find the Wix Toolset Visual Studio 2017 Extension echo Failed to find the WiX Toolset Visual Studio 2017 Extension
goto msbuild-not-found goto msbuild-not-found
) )
) )
@ -266,10 +266,6 @@ echo Try to run in a "Developer Command Prompt" or consult
echo https://github.com/nodejs/node/blob/master/BUILDING.md#windows-1 echo https://github.com/nodejs/node/blob/master/BUILDING.md#windows-1
goto exit goto exit
:wix-not-found
echo Build skipped. To generate installer, you need to install Wix.
goto install-doctools
:msbuild-found :msbuild-found
set project_generated= set project_generated=