From 52425d2ee77b9d8a5a497579d4df095a2878513c Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Sun, 6 Apr 2025 16:31:29 +0200 Subject: [PATCH] doc: update CI instructions MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The recent changes made to better protect CI against malicious PRs have changed how the `Retry` button can be used, it will no longer be useful when follow up commits were pushed due to the non-matching commit SHA. PR-URL: https://github.com/nodejs/node/pull/57743 Reviewed-By: Matteo Collina Reviewed-By: Paolo Insogna Reviewed-By: Michaël Zasso Reviewed-By: Chengzhong Wu Reviewed-By: Marco Ippolito Reviewed-By: Rafael Gonzaga Reviewed-By: Darshan Sen Reviewed-By: Ulises Gascón Reviewed-By: James M Snell --- doc/contributing/collaborator-guide.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/doc/contributing/collaborator-guide.md b/doc/contributing/collaborator-guide.md index e153c86061b..d883533d26e 100644 --- a/doc/contributing/collaborator-guide.md +++ b/doc/contributing/collaborator-guide.md @@ -252,13 +252,13 @@ request, try the "🔄 Re-run all jobs" button, on the right-hand side of the If there are Jenkins CI failures unrelated to the change in the pull request, try "Resume Build". It is in the left navigation of the relevant `node-test-pull-request` job. It will preserve all the green results from the -current job but re-run everything else. Start a fresh CI if more than seven days -have elapsed since the original failing CI as the compiled binaries for the -Windows and ARM platforms are only kept for seven days. +current job but re-run everything else. Start a fresh CI by pressing "Retry" +if more than seven days have elapsed since the original failing CI as the +compiled binaries for the Windows and ARM platforms are only kept for seven days. If new commits are pushed to the pull request branch after the latest Jenkins -CI run, a fresh CI run is required. It can be started by pressing "Retry" on -the left sidebar, or by adding the `request-ci` label to the pull request. +CI run, a fresh CI run is required. It can be started by adding the `request-ci` +label to the pull request. #### Useful Jenkins CI jobs