1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

buffer: Fix incorrect Buffer.compare behavior

Browse Source 
Fixes #7551

Signed-off-by: Trevor Norris <trev.norris@gmail.com>
This commit is contained in:
Feross Aboukhadijeh 2014-05-02 22:48:34 -07:00 committed by Trevor Norris
parent 41d8e10f0d
commit 522dda2f12
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/buffer.js
View File

@ -135,7 +135,7 @@ Buffer.compare = function compare(a, b) {
!(b instanceof Buffer))
throw new TypeError('Arguments must be Buffers');
return internal.compare(b, a);
return internal.compare(a, b);
};

8
test/simple/test-buffer.js
View File

@ -1048,10 +1048,10 @@ assert.equal(c.compare(d), 1);
assert.equal(d.compare(b), 1);
assert.equal(b.compare(d), -1);
assert.equal(Buffer.compare(b, c), 1);
assert.equal(Buffer.compare(c, d), -1);
assert.equal(Buffer.compare(d, b), -1);
assert.equal(Buffer.compare(b, d), 1);
assert.equal(Buffer.compare(b, c), -1);
assert.equal(Buffer.compare(c, d), 1);
assert.equal(Buffer.compare(d, b), 1);
assert.equal(Buffer.compare(b, d), -1);
assert.throws(function() {
var b = new Buffer(1);