test: check zlib version for createDeflateRaw
We are currenly builing Node with --shared-zlib which happens to be version 1.2.8. The test for zlib.createDeflateRaw is expected to fail but does not when using version 1.2.8. As far as I can tell the fix referred to in the comments was introduced in version 1.2.9: - Reject a window size of 256 bytes if not using the zlib wrapper This commit suggests adding a check for the version and skipping this assert if the version is less than 1.2.9. Refs: http://zlib.net/ChangeLog.txt PR-URL: https://github.com/nodejs/node/pull/13697 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This commit is contained in:
parent
a8979a6054
commit
51898575ae
@ -6,11 +6,15 @@ const assert = require('assert');
|
||||
const zlib = require('zlib');
|
||||
|
||||
// For raw deflate encoding, requests for 256-byte windows are rejected as
|
||||
// invalid by zlib.
|
||||
// (http://zlib.net/manual.html#Advanced)
|
||||
// invalid by zlib (http://zlib.net/manual.html#Advanced).
|
||||
// This check was introduced in version 1.2.9 and prior to that there was
|
||||
// no such rejection which is the reason for the version check below
|
||||
// (http://zlib.net/ChangeLog.txt).
|
||||
if (!/^1\.2\.[0-8]$/.test(process.versions.zlib)) {
|
||||
assert.throws(() => {
|
||||
zlib.createDeflateRaw({ windowBits: 8 });
|
||||
}, /^Error: Init error$/);
|
||||
}
|
||||
|
||||
// Regression tests for bugs in the validation logic.
|
||||
|
||||
|
Loading…
x
Reference in New Issue
Block a user