1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: check zlib version for createDeflateRaw

Browse Source 
We are currenly builing Node with --shared-zlib which happens to be
version 1.2.8. The test for zlib.createDeflateRaw is expected to fail
but does not when using version 1.2.8.

As far as I can tell the fix referred to in the comments was
introduced in version 1.2.9:
- Reject a window size of 256 bytes if not using the zlib wrapper

This commit suggests adding a check for the version and skipping this
assert if the version is less than 1.2.9.

Refs: http://zlib.net/ChangeLog.txt
PR-URL: https://github.com/nodejs/node/pull/13697
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This commit is contained in:
Daniel Bevenius 2017-06-15 13:29:30 +02:00
parent a8979a6054
commit 51898575ae
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
test/parallel/test-zlib-failed-init.js
View File

@ -6,11 +6,15 @@ const assert = require('assert');
const zlib = require('zlib'); const zlib = require('zlib');
// For raw deflate encoding, requests for 256-byte windows are rejected as // For raw deflate encoding, requests for 256-byte windows are rejected as
// invalid by zlib. // invalid by zlib (http://zlib.net/manual.html#Advanced).
// (http://zlib.net/manual.html#Advanced) // This check was introduced in version 1.2.9 and prior to that there was
assert.throws(() => { // no such rejection which is the reason for the version check below
zlib.createDeflateRaw({ windowBits: 8 }); // (http://zlib.net/ChangeLog.txt).
}, /^Error: Init error$/); if (!/^1\.2\.[0-8]$/.test(process.versions.zlib)) {
assert.throws(() => {
zlib.createDeflateRaw({ windowBits: 8 });
}, /^Error: Init error$/);
}
// Regression tests for bugs in the validation logic. // Regression tests for bugs in the validation logic.