1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: improve crypto coverage

Browse Source 
* check exception when ECDH curve is undefined
* check exception when getPublicKey format is invalid

PR-URL: https://github.com/nodejs/node/pull/11279
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
樋口　彰 2017-02-10 13:06:10 +09:00 committed by James M Snell
parent d9a14b7aad
commit 513d9bb8aa
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
test/parallel/test-crypto-dh.js
View File

@ -182,6 +182,10 @@ let firstByte = ecdh1.getPublicKey('buffer', 'compressed')[0];
assert(firstByte === 2 || firstByte === 3); assert(firstByte === 2 || firstByte === 3);
firstByte = ecdh1.getPublicKey('buffer', 'hybrid')[0]; firstByte = ecdh1.getPublicKey('buffer', 'hybrid')[0];
assert(firstByte === 6 || firstByte === 7); assert(firstByte === 6 || firstByte === 7);
// format value should be string
assert.throws(() => {
ecdh1.getPublicKey('buffer', 10);
}, /^TypeError: Bad format: 10$/);
// ECDH should check that point is on curve // ECDH should check that point is on curve
const ecdh3 = crypto.createECDH('secp256k1'); const ecdh3 = crypto.createECDH('secp256k1');
@ -277,3 +281,8 @@ ecdh5.setPrivateKey(cafebabeKey, 'hex');
// Verify object state did not change. // Verify object state did not change.
assert.strictEqual(ecdh5.getPrivateKey('hex'), cafebabeKey); assert.strictEqual(ecdh5.getPrivateKey('hex'), cafebabeKey);
}); });
// invalid test: curve argument is undefined
assert.throws(() => {
crypto.createECDH();
}, /^TypeError: "curve" argument should be a string$/);