1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix nits in test-fs-mkdir-rmdir.js

Browse Source 
* Add common.mustCall().
* Add check for error existence, not only for error details.
* Use test(), not match() in a boolean context.
* Properly reverse meanings of assert messages.

PR-URL: https://github.com/nodejs/node/pull/13680
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This commit is contained in:
Vse Mozhet Byt 2017-06-14 17:42:39 +03:00
parent fe2caf6fb5
commit 50b35460e3
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
test/parallel/test-fs-mkdir-rmdir.js
View File

@ -24,14 +24,15 @@ fs.rmdirSync(d);
assert(!common.fileExists(d)); assert(!common.fileExists(d));
// Similarly test the Async version // Similarly test the Async version
fs.mkdir(d, 0o666, function(err) { fs.mkdir(d, 0o666, common.mustCall(function(err) {
assert.ifError(err); assert.ifError(err);
fs.mkdir(d, 0o666, function(err) { fs.mkdir(d, 0o666, common.mustCall(function(err) {
assert.ok(err.message.match(/^EEXIST/), 'got EEXIST message'); assert.ok(err, 'got no error');
assert.strictEqual(err.code, 'EEXIST', 'got EEXIST code'); assert.ok(/^EEXIST/.test(err.message), 'got no EEXIST message');
assert.strictEqual(err.path, d, 'got proper path for EEXIST'); assert.strictEqual(err.code, 'EEXIST', 'got no EEXIST code');
assert.strictEqual(err.path, d, 'got no proper path for EEXIST');
fs.rmdir(d, assert.ifError); fs.rmdir(d, assert.ifError);
}); }));
}); }));