From 50b1cb39bd11811866b77b74b2822620aeb405cb Mon Sep 17 00:00:00 2001 From: "Sakthipriyan Vairamani (thefourtheye)" Date: Thu, 8 Mar 2018 00:42:41 +0530 Subject: [PATCH] src: fix deprecation id for non-string env value This is a follow-up of https://github.com/nodejs/node/pull/18990. A new deprecation id was assigned in it, but it was not reflected in code and test. PR-URL: https://github.com/nodejs/node/pull/19209 Reviewed-By: Tiancheng "Timothy" Gu Reviewed-By: Joyee Cheung --- src/node.cc | 2 +- test/parallel/test-process-env-deprecation.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/node.cc b/src/node.cc index 9a1c4eeb6a7..2e44e249a0d 100644 --- a/src/node.cc +++ b/src/node.cc @@ -2667,7 +2667,7 @@ static void EnvSetter(Local property, "Assigning any value other than a string, number, or boolean to a " "process.env property is deprecated. Please make sure to convert the " "value to a string before setting process.env with it.", - "DEP00XX").IsNothing()) + "DEP0104").IsNothing()) return; } #ifdef __POSIX__ diff --git a/test/parallel/test-process-env-deprecation.js b/test/parallel/test-process-env-deprecation.js index c3b9ea6da37..68817b320b4 100644 --- a/test/parallel/test-process-env-deprecation.js +++ b/test/parallel/test-process-env-deprecation.js @@ -9,7 +9,7 @@ common.expectWarning( 'Assigning any value other than a string, number, or boolean to a ' + 'process.env property is deprecated. Please make sure to convert the value ' + 'to a string before setting process.env with it.', - 'DEP00XX' + 'DEP0104' ); process.env.ABC = undefined;