1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: replace assert.throws with common.expectsError

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/17445
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Leko 2017-12-04 16:07:45 +09:00 committed by Jon Moss
parent b73e66e949
commit 50afd901ea
1 changed files with 9 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
test/addons-napi/test_error/test.js
View File

@ -60,29 +60,26 @@ assert.throws(() => {
test_error.throwTypeError(); test_error.throwTypeError();
}, /^TypeError: type error$/); }, /^TypeError: type error$/);
assert.throws( common.expectsError(
() => test_error.throwErrorCode(), () => test_error.throwErrorCode(),
common.expectsError({ {
code: 'ERR_TEST_CODE', code: 'ERR_TEST_CODE',
message: 'Error [error]' message: 'Error [error]'
}) });
);
assert.throws( common.expectsError(
() => test_error.throwRangeErrorCode(), () => test_error.throwRangeErrorCode(),
common.expectsError({ {
code: 'ERR_TEST_CODE', code: 'ERR_TEST_CODE',
message: 'RangeError [range error]' message: 'RangeError [range error]'
}) });
);
assert.throws( common.expectsError(
() => test_error.throwTypeErrorCode(), () => test_error.throwTypeErrorCode(),
common.expectsError({ {
code: 'ERR_TEST_CODE', code: 'ERR_TEST_CODE',
message: 'TypeError [type error]' message: 'TypeError [type error]'
}) });
);
let error = test_error.createError(); let error = test_error.createError();
assert.ok(error instanceof Error, 'expected error to be an instance of Error'); assert.ok(error instanceof Error, 'expected error to be an instance of Error');