1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: improve test-http-allow-req-after-204-res

Browse Source 
* use const instead of var
* use common.mustCall to control functions execution
* use assert.strictEqual instead of assert.equal
* use arrow functions

PR-URL: https://github.com/nodejs/node/pull/10503
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
Adrian Estrada 2016-12-30 09:28:33 -05:00 committed by James M Snell
parent f60aba2fd4
commit 509ff1b9e4
1 changed files with 15 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
test/parallel/test-http-allow-req-after-204-res.js
View File

@ -1,35 +1,32 @@
'use strict';
require('../common');
var http = require('http');
var assert = require('assert');
const common = require('../common');
const http = require('http');
const assert = require('assert');
// first 204 or 304 works, subsequent anything fails
var codes = [204, 200];
const codes = [204, 200];
// Methods don't really matter, but we put in something realistic.
var methods = ['DELETE', 'DELETE'];
const methods = ['DELETE', 'DELETE'];
var server = http.createServer(function(req, res) {
var code = codes.shift();
assert.equal('number', typeof code);
const server = http.createServer(common.mustCall((req, res) => {
const code = codes.shift();
assert.strictEqual(typeof code, 'number');
assert.ok(code > 0);
console.error('writing %d response', code);
res.writeHead(code, {});
res.end();
});
}, codes.length));
function nextRequest() {
var method = methods.shift();
console.error('writing request: %s', method);
const method = methods.shift();
var request = http.request({
const request = http.request({
port: server.address().port,
method: method,
path: '/'
}, function(response) {
response.on('end', function() {
}, common.mustCall((response) => {
response.on('end', common.mustCall(() => {
if (methods.length === 0) {
console.error('close server');
server.close();
} else {
// throws error:
@ -37,9 +34,9 @@ function nextRequest() {
// works just fine:
//process.nextTick(nextRequest);
}
});
}));
response.resume();
});
}));
request.end();
}