1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: invalid package.json causes error when require()ing in directory

Browse Source 
Requiring a file from a directory that contains an invalid package.json
file should throw an error.

PR-URL: https://github.com/nodejs/node/pull/10044
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Sam Shull 2016-12-01 09:55:07 -08:00 committed by Italo A. Casas
parent 00ea286800
commit 4f486aa661
3 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
test/fixtures/packages/invalid/index.js vendored Normal file
View File

@ -0,0 +1 @@
exports.ok = 'ok';

1
test/fixtures/packages/invalid/package.json vendored Normal file
View File

@ -0,0 +1 @@
{,}

7
test/sequential/test-module-loading.js
View File

@ -69,6 +69,13 @@ assert.strictEqual(threeFolder, threeIndex);
assert.notStrictEqual(threeFolder, three); assert.notStrictEqual(threeFolder, three);
console.error('test package.json require() loading'); console.error('test package.json require() loading');
assert.throws(
function() {
require('../fixtures/packages/invalid');
},
/^SyntaxError: Error parsing \S+: Unexpected token , in JSON at position 1$/
);
assert.strictEqual(require('../fixtures/packages/index').ok, 'ok', assert.strictEqual(require('../fixtures/packages/index').ok, 'ok',
'Failed loading package'); 'Failed loading package');
assert.strictEqual(require('../fixtures/packages/main').ok, 'ok', assert.strictEqual(require('../fixtures/packages/main').ok, 'ok',