1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

zlib: make “bare” constants un-enumerable

Browse Source 
We prefer for users to use `zlib.constants.XXX` instead of `zlib.XXX`.
Having both enumerable means that inspecting the `zlib` module
shows both variants, making the output significantly longer and
redundant.

PR-URL: https://github.com/nodejs/node/pull/24824
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
Anna Henningsen 2018-12-04 10:00:09 +01:00
parent 26b58eabc6
commit 4eee55d354
No known key found for this signature in database
GPG Key ID: 9C63F3A6CD2AD8F9
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/zlib.js
View File

@ -786,6 +786,6 @@ const bkeys = Object.keys(constants);
for (var bk = 0; bk < bkeys.length; bk++) { for (var bk = 0; bk < bkeys.length; bk++) {
var bkey = bkeys[bk]; var bkey = bkeys[bk];
Object.defineProperty(module.exports, bkey, { Object.defineProperty(module.exports, bkey, {
enumerable: true, value: constants[bkey], writable: false enumerable: false, value: constants[bkey], writable: false
}); });
} }