1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

src: disable harmony object literals

Browse Source 
Per the discussion in https://github.com/iojs/io.js/pull/272, upstream
V8 has disabled Harmony object literals for the time being.  Do the
same for feature parity.

PR-URL: https://github.com/iojs/io.js/pull/272
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Domenic Denicola <domenic@domenicdenicola.com>
This commit is contained in:
Ben Noordhuis 2015-01-09 17:03:21 +01:00
parent a2751e3e1e
commit 4e58211bb7
2 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/node.cc
View File

@ -3360,6 +3360,8 @@ void Init(int* argc,
// again when we upgrade. // again when we upgrade.
V8::SetFlagsFromString("--noharmony_classes", V8::SetFlagsFromString("--noharmony_classes",
sizeof("--noharmony_classes") - 1); sizeof("--noharmony_classes") - 1);
V8::SetFlagsFromString("--noharmony_object_literals",
sizeof("--noharmony_object_literals") - 1);
#if defined(NODE_V8_OPTIONS) #if defined(NODE_V8_OPTIONS)
// Should come before the call to V8::SetFlagsFromCommandLine() // Should come before the call to V8::SetFlagsFromCommandLine()

10
test/parallel/test-v8-features.js
View File

@ -19,3 +19,13 @@ var args = ['--harmony_classes', '--use_strict', '-p', 'class C {}'];
var cp = spawnSync(process.execPath, args); var cp = spawnSync(process.execPath, args);
assert.equal(cp.status, 0); assert.equal(cp.status, 0);
assert.equal(cp.stdout.toString('utf8').trim(), '[Function: C]'); assert.equal(cp.stdout.toString('utf8').trim(), '[Function: C]');
// Now do the same for --harmony_object_literals.
assert.throws(function() { eval('({ f() {} })'); }, SyntaxError);
v8.setFlagsFromString('--harmony_object_literals');
eval('({ f() {} })');
var args = ['--harmony_object_literals', '-p', '({ f() {} })'];
var cp = spawnSync(process.execPath, args);
assert.equal(cp.status, 0);
assert.equal(cp.stdout.toString('utf8').trim(), '{ f: [Function: f] }');