1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

benchmark: fix http/simple.js benchmark

Browse Source 
autocannon appears to have trouble recognizing URLs that contain true
or false within them. Use 0 or 1 instead to represent the same.

PR-URL: https://github.com/nodejs/node/pull/17583
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This commit is contained in:
Anatoli Papirovski 2017-12-09 17:32:48 -05:00
parent f3aaaa52b7
commit 4df7c190bf
No known key found for this signature in database
GPG Key ID: 614E2E1ABEB4B2C0
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
benchmark/fixtures/simple-http-server.js
View File

@ -34,7 +34,7 @@ module.exports = http.createServer(function(req, res) {
const arg = params[2]; const arg = params[2];
const n_chunks = parseInt(params[3], 10); const n_chunks = parseInt(params[3], 10);
const resHow = params.length >= 5 ? params[4] : 'normal'; const resHow = params.length >= 5 ? params[4] : 'normal';
const chunkedEnc = params.length >= 6 && params[5] === 'false' ? false : true; const chunkedEnc = params.length >= 6 && params[5] === '0' ? false : true;
var status = 200; var status = 200;
var n, i; var n, i;

4
benchmark/http/simple.js
View File

@ -8,14 +8,14 @@ const bench = common.createBenchmark(main, {
len: [4, 1024, 102400], len: [4, 1024, 102400],
chunks: [1, 4], chunks: [1, 4],
c: [50, 500], c: [50, 500],
chunkedEnc: ['true', 'false'], chunkedEnc: [1, 0],
res: ['normal', 'setHeader', 'setHeaderWH'] res: ['normal', 'setHeader', 'setHeaderWH']
}); });
function main(conf) { function main(conf) {
process.env.PORT = PORT; process.env.PORT = PORT;
var server = require('../fixtures/simple-http-server.js') var server = require('../fixtures/simple-http-server.js')
.listen(process.env.PORT || common.PORT) .listen(PORT)
.on('listening', function() { .on('listening', function() {
const path = const path =
`/${conf.type}/${conf.len}/${conf.chunks}/${conf.res}/${conf.chunkedEnc}`; `/${conf.type}/${conf.len}/${conf.chunks}/${conf.res}/${conf.chunkedEnc}`;