1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

readline: make Symbol.asyncIterator support stable

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/26989
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This commit is contained in:
Matteo Collina 2019-04-01 10:07:57 +02:00
parent 1d8298a5b6
commit 4de5e0a996
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
doc/api/readline.md
View File

@ -312,9 +312,13 @@ The `rl.write()` method will write the data to the `readline` `Interface`'s
### rl\[Symbol.asyncIterator\]() ### rl\[Symbol.asyncIterator\]()
<!-- YAML <!-- YAML
added: v11.4.0 added: v11.4.0
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/26989
description: Symbol.asyncIterator support is no longer experimental.
--> -->
> Stability: 1 - Experimental > Stability: 2 - Stable
* Returns: {AsyncIterator} * Returns: {AsyncIterator}

3
lib/readline.js
View File

@ -33,7 +33,6 @@ const {
} = require('internal/errors').codes; } = require('internal/errors').codes;
const { validateString } = require('internal/validators'); const { validateString } = require('internal/validators');
const { inspect } = require('internal/util/inspect'); const { inspect } = require('internal/util/inspect');
const { emitExperimentalWarning } = require('internal/util');
const EventEmitter = require('events'); const EventEmitter = require('events');
const { const {
CSI, CSI,
@ -1075,8 +1074,6 @@ Interface.prototype._ttyWrite = function(s, key) {
}; };
Interface.prototype[Symbol.asyncIterator] = function() { Interface.prototype[Symbol.asyncIterator] = function() {
emitExperimentalWarning('readline Interface [Symbol.asyncIterator]');
if (this[kLineObjectStream] === undefined) { if (this[kLineObjectStream] === undefined) {
if (Readable === undefined) { if (Readable === undefined) {
Readable = require('stream').Readable; Readable = require('stream').Readable;