1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: skip test-fs-readdir-ucs2 if no support

Browse Source 
If the filesystem does not support UCS2, do not run the test.

PR-URL: https://github.com/nodejs/node/pull/14029
Fixes: https://github.com/nodejs/node/issues/14028
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This commit is contained in:
Rich Trott 2017-07-01 08:14:28 -07:00 committed by Refael Ackermann
parent 2d2986ae72
commit 4dd7d09723
No known key found for this signature in database
GPG Key ID: CD704BD80FDDDB64
2 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
test/parallel/parallel.status
View File

@ -13,7 +13,6 @@ prefix parallel
[$system==macos]
[$arch==arm || $arch==arm64]
test-fs-readdir-ucs2 : PASS,FLAKY
test-npm-install: PASS,FLAKY
[$system==solaris] # Also applies to SmartOS

16
test/parallel/test-fs-readdir-ucs2.js
View File

@ -14,16 +14,18 @@ const root = Buffer.from(`${common.tmpDir}${path.sep}`);
const filebuff = Buffer.from(filename, 'ucs2');
const fullpath = Buffer.concat([root, filebuff]);
fs.closeSync(fs.openSync(fullpath, 'w+'));
try {
fs.closeSync(fs.openSync(fullpath, 'w+'));
} catch (e) {
if (e.code === 'EINVAL')
common.skip('test requires filesystem that supports UCS2');
throw e;
}
fs.readdir(common.tmpDir, 'ucs2', (err, list) => {
fs.readdir(common.tmpDir, 'ucs2', common.mustCall((err, list) => {
assert.ifError(err);
assert.strictEqual(1, list.length);
const fn = list[0];
assert.deepStrictEqual(filebuff, Buffer.from(fn, 'ucs2'));
assert.strictEqual(fn, filename);
});
process.on('exit', () => {
fs.unlinkSync(fullpath);
});
}));