1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: ignore connection errors for hostname check

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/14073
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
Refael Ackermann 2017-07-04 10:04:54 -04:00
parent 18069523f8
commit 4d7946aec3
No known key found for this signature in database
GPG Key ID: CD704BD80FDDDB64
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
test/parallel/test-http-hostname-typechecking.js
View File

@ -18,10 +18,12 @@ vals.forEach((v) => {
assert.throws(() => http.request({host: v}), errHost);
});
// These values are OK and should not throw synchronously
// These values are OK and should not throw synchronously.
// Only testing for 'hostname' validation so ignore connection errors.
const dontCare = () => {};
['', undefined, null].forEach((v) => {
assert.doesNotThrow(() => {
http.request({hostname: v}).on('error', () => {}).end();
http.request({host: v}).on('error', () => {}).end();
http.request({hostname: v}).on('error', dontCare).end();
http.request({host: v}).on('error', dontCare).end();
});
});