1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

doc: examples for fast-tracking regression fixes

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/17379
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
Refael Ackermann 2017-11-26 16:43:20 -05:00 committed by James M Snell
parent 91c1ccd84f
commit 4c8bedf8b4
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
COLLABORATOR_GUIDE.md
View File

@ -127,12 +127,14 @@ Before landing pull requests, sufficient time should be left for input
from other Collaborators. In general, leave at least 48 hours during the from other Collaborators. In general, leave at least 48 hours during the
week and 72 hours over weekends to account for international time week and 72 hours over weekends to account for international time
differences and work schedules. However, certain types of pull requests differences and work schedules. However, certain types of pull requests
can be fast-tracked and may be landed after a shorter delay: can be fast-tracked and may be landed after a shorter delay. For example:
* Focused changes that affect only documentation and/or the test suite. * Focused changes that affect only documentation and/or the test suite:
`code-and-learn` and `good-first-issue` pull requests typically fall * `code-and-learn` tasks typically fall into this category.
into this category. * `good-first-issue` pull requests may also be suitable.
* Changes that fix regressions. * Changes that fix regressions:
* Regressions that break the workflow (red CI or broken compilation).
* Regressions that happen right before a release, or reported soon after.
When a pull request is deemed suitable to be fast-tracked, label it with When a pull request is deemed suitable to be fast-tracked, label it with
`fast-track`. The pull request can be landed once 2 or more Collaborators `fast-track`. The pull request can be landed once 2 or more Collaborators