1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: add coverage for vm's breakOnSigint option

Browse Source 
The breakOnSigint option follows different code paths, depending
on the number of listeners for SIGINT. This commit updates the
existing test to vary the number of SIGINT handlers.

PR-URL: https://github.com/nodejs/node/pull/12512
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
cjihrig 2017-04-19 10:51:03 -04:00 committed by David Cai
parent 14c6ae81fb
commit 4bcbefccce
1 changed files with 19 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
test/parallel/test-vm-sigint.js
View File

@ -5,11 +5,6 @@ const vm = require('vm');
const spawn = require('child_process').spawn; const spawn = require('child_process').spawn;
const methods = [
'runInThisContext',
'runInContext'
];
if (common.isWindows) { if (common.isWindows) {
// No way to send CTRL_C_EVENT to processes from JS right now. // No way to send CTRL_C_EVENT to processes from JS right now.
common.skip('platform not supported'); common.skip('platform not supported');
@ -18,7 +13,9 @@ if (common.isWindows) {
if (process.argv[2] === 'child') { if (process.argv[2] === 'child') {
const method = process.argv[3]; const method = process.argv[3];
const listeners = +process.argv[4];
assert.ok(method); assert.ok(method);
assert.ok(typeof listeners, 'number');
const script = `process.send('${method}'); while(true) {}`; const script = `process.send('${method}'); while(true) {}`;
const args = method === 'runInContext' ? const args = method === 'runInContext' ?
@ -26,23 +23,28 @@ if (process.argv[2] === 'child') {
[]; [];
const options = { breakOnSigint: true }; const options = { breakOnSigint: true };
for (let i = 0; i < listeners; i++)
process.on('SIGINT', common.noop);
assert.throws(() => { vm[method](script, ...args, options); }, assert.throws(() => { vm[method](script, ...args, options); },
/^Error: Script execution interrupted\.$/); /^Error: Script execution interrupted\.$/);
return; return;
} }
for (const method of methods) { for (const method of ['runInThisContext', 'runInContext']) {
const child = spawn(process.execPath, [__filename, 'child', method], { for (const listeners of [0, 1, 2]) {
stdio: [null, 'pipe', 'inherit', 'ipc'] const args = [__filename, 'child', method, listeners];
}); const child = spawn(process.execPath, args, {
stdio: [null, 'pipe', 'inherit', 'ipc']
});
child.on('message', common.mustCall(() => { child.on('message', common.mustCall(() => {
process.kill(child.pid, 'SIGINT'); process.kill(child.pid, 'SIGINT');
})); }));
child.on('close', common.mustCall((code, signal) => { child.on('close', common.mustCall((code, signal) => {
assert.strictEqual(signal, null); assert.strictEqual(signal, null);
assert.strictEqual(code, 0); assert.strictEqual(code, 0);
})); }));
}
} }