1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

doc: simplify author ready

Browse Source 
The label should be applied early on. Otherwise there is little
benefit using this label at all.

PR-URL: https://github.com/nodejs/node/pull/24893
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
This commit is contained in:
Ruben Bridgewater 2018-12-07 14:58:09 +01:00 committed by Rich Trott
parent 5652cb0b53
commit 4aabd7ed64
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
COLLABORATOR_GUIDE.md
View File

@ -72,8 +72,7 @@ issues and pull requests can always be re-opened if necessary.
A pull request is _author ready_ when:
* There is a CI run in progress or completed.
* There are at least two Collaborator approvals, or at least one approval if the
pull request is older than 7 days.
* There is at least one Collaborator approval.
* There are no outstanding review comments.
Please always add the `author ready` label to the pull request in that case.