1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: replace [].join() with ''.repeat()

Browse Source 
Replace [].join calls with the more modern .repeat

PR-URL: https://github.com/nodejs/node/pull/12305
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
This commit is contained in:
Jackson Tian 2017-04-10 23:24:47 +08:00 committed by Benjamin Gruenbaum
parent ddcd93aaeb
commit 4a782e12a8
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/parallel/test-child-process-send-utf8.js
View File

@ -24,7 +24,7 @@ const common = require('../common');
const assert = require('assert');
const fork = require('child_process').fork;
const expected = Array(1e5).join('ßßßß');
const expected = 'ßßßß'.repeat(1e5 - 1);
if (process.argv[2] === 'child') {
process.send(expected);
} else {

8
test/parallel/test-stringbytes-external.js
View File

@ -44,9 +44,9 @@ assert.strictEqual(b[1], 0);
assert.strictEqual(ucs2_control, c);
// now create big strings
const size = 1 + (1 << 20);
write_str = Array(size).join(write_str);
ucs2_control = Array(size).join(ucs2_control);
const size = 1 << 20;
write_str = write_str.repeat(size);
ucs2_control = ucs2_control.repeat(size);
// check resultant buffer and output string
b = Buffer.from(write_str, 'ucs2');
@ -131,7 +131,7 @@ const PRE_3OF4_APEX = Math.ceil((EXTERN_APEX / 4) * 3) - RADIOS;
// https://github.com/nodejs/node/issues/1024
{
const a = Array(1 << 20).join('x');
const a = 'x'.repeat(1 << 20 - 1);
const b = Buffer.from(a, 'ucs2').toString('ucs2');
const c = Buffer.from(b, 'utf8').toString('utf8');