1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix flaky addons/callback-scope/test-resolve-async

Browse Source 
Fixes: https://github.com/nodejs/node/issues/22668
PR-URL: https://github.com/nodejs/node/pull/22664
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
Anna Henningsen 2018-09-02 20:15:51 +02:00 committed by Daniel Bevenius
parent 32957100dd
commit 4a5886cb8a
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/addons/callback-scope/test-resolve-async.js
View File

@ -4,7 +4,9 @@ const common = require('../../common');
const assert = require('assert');
const { testResolveAsync } = require(`./build/${common.buildType}/binding`);
// Checks that resolving promises from C++ works.
let called = false;
testResolveAsync().then(() => { called = true; });
setTimeout(() => { assert(called); }, common.platformTimeout(50));
process.on('beforeExit', () => { assert(called); });