1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

src: emit 'params' instead of 'data' for NodeTracing.dataCollected

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/24949
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Kelvin Jin 2018-12-10 15:50:22 -08:00 committed by Rich Trott
parent 1c52dccc54
commit 49f1db47e2
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/inspector/tracing_agent.cc
View File

@ -31,7 +31,7 @@ class InspectorTraceWriter : public node::tracing::AsyncTraceWriter {
return; return;
json_writer_.reset(); json_writer_.reset();
std::ostringstream result( std::ostringstream result(
"{\"method\":\"NodeTracing.dataCollected\",\"data\":", "{\"method\":\"NodeTracing.dataCollected\",\"params\":",
std::ostringstream::ate); std::ostringstream::ate);
result << stream_.str(); result << stream_.str();
result << "}"; result << "}";

2
test/parallel/test-inspector-tracing-domain.js
View File

@ -60,7 +60,7 @@ async function test() {
await generateTrace(); await generateTrace();
JSON.stringify(await post('NodeTracing.stop', { traceConfig })); JSON.stringify(await post('NodeTracing.stop', { traceConfig }));
session.disconnect(); session.disconnect();
assert(traceNotification.data.value.length > 0); assert(traceNotification.params.value.length > 0);
assert(tracingComplete); assert(tracingComplete);
clearInterval(interval); clearInterval(interval);
console.log('Success'); console.log('Success');

4
test/parallel/test-trace-events-dynamic-enable.js
View File

@ -28,8 +28,8 @@ async function test() {
const events = []; const events = [];
let tracingComplete = false; let tracingComplete = false;
session.on('NodeTracing.dataCollected', (n) => { session.on('NodeTracing.dataCollected', (n) => {
assert.ok(n && n.data && n.data.value); assert.ok(n && n.params && n.params.value);
events.push(...n.data.value); // append the events. events.push(...n.params.value); // append the events.
}); });
session.on('NodeTracing.tracingComplete', () => tracingComplete = true); session.on('NodeTracing.tracingComplete', () => tracingComplete = true);