1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: improve code in test-fs-readfile-error

Browse Source 
* use const instead of var
* use common.mustCall to control the functions execution automatically
* use assert.strictEqual instead of assert.equal
* use assert.notStrictEqual instead of assert.notEqual
* use arrow functions

PR-URL: https://github.com/nodejs/node/pull/10367
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Adrian Estrada 2016-12-20 19:27:56 -05:00 committed by Luigi Pinca
parent 89c8f58921
commit 499efbd085
1 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
test/parallel/test-fs-readfile-error.js
View File

@ -1,8 +1,8 @@
'use strict'; 'use strict';
var common = require('../common'); const common = require('../common');
var assert = require('assert'); const assert = require('assert');
var exec = require('child_process').exec; const exec = require('child_process').exec;
var path = require('path'); const path = require('path');
// `fs.readFile('/')` does not fail on FreeBSD, because you can open and read // `fs.readFile('/')` does not fail on FreeBSD, because you can open and read
// the directory there. // the directory there.
@ -12,23 +12,23 @@ if (process.platform === 'freebsd') {
} }
function test(env, cb) { function test(env, cb) {
var filename = path.join(common.fixturesDir, 'test-fs-readfile-error.js'); const filename = path.join(common.fixturesDir, 'test-fs-readfile-error.js');
var execPath = '"' + process.execPath + '" "' + filename + '"'; const execPath = '"' + process.execPath + '" "' + filename + '"';
var options = { env: Object.assign(process.env, env) }; const options = { env: Object.assign(process.env, env) };
exec(execPath, options, function(err, stdout, stderr) { exec(execPath, options, common.mustCall((err, stdout, stderr) => {
assert(err); assert(err);
assert.equal(stdout, ''); assert.strictEqual(stdout, '');
assert.notEqual(stderr, ''); assert.notStrictEqual(stderr, '');
cb('' + stderr); cb('' + stderr);
}); }));
} }
test({ NODE_DEBUG: '' }, common.mustCall(function(data) { test({ NODE_DEBUG: '' }, common.mustCall((data) => {
assert(/EISDIR/.test(data)); assert(/EISDIR/.test(data));
assert(!/test-fs-readfile-error/.test(data)); assert(!/test-fs-readfile-error/.test(data));
})); }));
test({ NODE_DEBUG: 'fs' }, common.mustCall(function(data) { test({ NODE_DEBUG: 'fs' }, common.mustCall((data) => {
assert(/EISDIR/.test(data)); assert(/EISDIR/.test(data));
assert(/test-fs-readfile-error/.test(data)); assert(/test-fs-readfile-error/.test(data));
})); }));