zlib: remove unused parameters
When `checkRangesOrGetDefault` calls `checkFiniteNumber`, the latter function only has two parameters, so `lower` and `upper` don't need to be passed for validation. PR-URL: https://github.com/nodejs/node/pull/22115 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This commit is contained in:
parent
e570ae79f5
commit
493e6d45d9
@ -198,12 +198,12 @@ function checkFiniteNumber(number, name) {
|
|||||||
throw err;
|
throw err;
|
||||||
}
|
}
|
||||||
|
|
||||||
// 1. Returns def for undefined and NaN
|
// 1. Returns def for number when it's undefined or NaN
|
||||||
// 2. Returns number for finite numbers >= lower and <= upper
|
// 2. Returns number for finite numbers >= lower and <= upper
|
||||||
// 3. Throws ERR_INVALID_ARG_TYPE for non-numbers
|
// 3. Throws ERR_INVALID_ARG_TYPE for non-numbers
|
||||||
// 4. Throws ERR_OUT_OF_RANGE for infinite numbers or numbers > upper or < lower
|
// 4. Throws ERR_OUT_OF_RANGE for infinite numbers or numbers > upper or < lower
|
||||||
function checkRangesOrGetDefault(number, name, lower, upper, def) {
|
function checkRangesOrGetDefault(number, name, lower, upper, def) {
|
||||||
if (!checkFiniteNumber(number, name, lower, upper)) {
|
if (!checkFiniteNumber(number, name)) {
|
||||||
return def;
|
return def;
|
||||||
}
|
}
|
||||||
if (number < lower || number > upper) {
|
if (number < lower || number > upper) {
|
||||||
|
Loading…
x
Reference in New Issue
Block a user