1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fs: use fs.writev() internally

Browse Source 
Avoid using internal API in fs implementation.

PR-URL: https://github.com/nodejs/node/pull/29189
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Robert Nagy 2019-08-17 23:36:59 +02:00 committed by Rich Trott
parent 5116a6a9b4
commit 490ec9b9c9
1 changed files with 1 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
lib/internal/fs/streams.js
View File

@ -2,10 +2,6 @@
const { Math, Object } = primordials; const { Math, Object } = primordials;
const {
FSReqCallback,
writeBuffers
} = internalBinding('fs');
const { const {
ERR_INVALID_ARG_TYPE, ERR_INVALID_ARG_TYPE,
ERR_OUT_OF_RANGE ERR_OUT_OF_RANGE
@ -325,18 +321,6 @@ WriteStream.prototype._write = function(data, encoding, cb) {
}; };
function writev(fd, chunks, position, callback) {
function wrapper(err, written) {
// Retain a reference to chunks so that they can't be GC'ed too soon.
callback(err, written || 0, chunks);
}
const req = new FSReqCallback();
req.oncomplete = wrapper;
writeBuffers(fd, chunks, position, req);
}
WriteStream.prototype._writev = function(data, cb) { WriteStream.prototype._writev = function(data, cb) {
if (typeof this.fd !== 'number') { if (typeof this.fd !== 'number') {
return this.once('open', function() { return this.once('open', function() {
@ -356,7 +340,7 @@ WriteStream.prototype._writev = function(data, cb) {
size += chunk.length; size += chunk.length;
} }
writev(this.fd, chunks, this.pos, function(er, bytes) { fs.writev(this.fd, chunks, this.pos, function(er, bytes) {
if (er) { if (er) {
self.destroy(); self.destroy();
return cb(er); return cb(er);