1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: add hasCrypto check to test-debug-usage

Browse Source 
When configuring --without-ssl test-debug-usage.js fails with the
following error:

assert.js:82
  throw new assert.AssertionError({
  ^
AssertionError: false == true
    at ChildProcess.<anonymous>
(/Users/danielbevenius/work/nodejs/node/test/parallel/test-debug-usage.js:24:5)
    at ChildProcess.<anonymous>
(/Users/danielbevenius/work/nodejs/node/test/common.js:461:15)
    at emitTwo (events.js:125:13)
    at ChildProcess.emit (events.js:213:7)
    at Process.ChildProcess._handle.onexit
(internal/child_process.js:208:12)

But the underlying error is the following:

(node:55665) [DEP0068] DeprecationWarning: `node debug` is deprecated.
Please use `node inspect` instead.
internal/util.js:83
    throw new Error('Node.js is not compiled with openssl crypto
support');
    ^

Error: Node.js is not compiled with openssl crypto support
    at Object.exports.assertCrypto (internal/util.js:83:11)
    at crypto.js:28:14
    at NativeModule.compile (bootstrap_node.js:559:7)
    at NativeModule.require (bootstrap_node.js:500:18)
    at node-inspect/lib/internal/inspect_client.js:24:16
    at NativeModule.compile (bootstrap_node.js:559:7)
    at NativeModule.require (bootstrap_node.js:500:18)
    at node-inspect/lib/_inspect.js:39:5
    at NativeModule.compile (bootstrap_node.js:559:7)
    at Function.NativeModule.require (bootstrap_node.js:500:18)

assert.js:82
  throw new assert.AssertionError({
  ^
AssertionError: false == true
    at ChildProcess.<anonymous>
(/Users/danielbevenius/work/nodejs/node/test/parallel/test-debug-usage.js:25:5)
    at ChildProcess.<anonymous>
(/Users/danielbevenius/work/nodejs/node/test/common.js:461:15)
    at emitTwo (events.js:125:13)
    at ChildProcess.emit (events.js:213:7)
    at Process.ChildProcess._handle.onexit
(internal/child_process.js:208:12)

This commit adds a check for crypto like some of the other tests do.

PR-URL: https://github.com/nodejs/node/pull/12357
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This commit is contained in:
Daniel Bevenius 2017-04-12 12:28:33 +02:00 committed by Anna Henningsen
parent 4749ec2aa3
commit 48f780d8ea
No known key found for this signature in database
GPG Key ID: D8B9F5AEAE84E4CF
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
test/parallel/test-debug-usage.js
View File

@ -3,6 +3,11 @@ const common = require('../common');
const assert = require('assert');
const spawn = require('child_process').spawn;
if (!common.hasCrypto) {
common.skip('missing crypto');
return;
}
const child = spawn(process.execPath, ['debug']);
child.stderr.setEncoding('utf8');