1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

url: added space to class string of iterator objects

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/17558
Fixes: https://github.com/nodejs/node/issues/17540
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Haejin Jo 2017-12-08 18:23:45 -08:00 committed by Anna Henningsen
parent f96a86cac5
commit 486290b1fe
No known key found for this signature in database
GPG Key ID: 9C63F3A6CD2AD8F9
3 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/internal/url.js
View File

@ -1198,7 +1198,7 @@ function createSearchParamsIterator(target, kind) {
// https://heycam.github.io/webidl/#dfn-iterator-prototype-object // https://heycam.github.io/webidl/#dfn-iterator-prototype-object
const URLSearchParamsIteratorPrototype = Object.create(IteratorPrototype); const URLSearchParamsIteratorPrototype = Object.create(IteratorPrototype);
defineIDLClass(URLSearchParamsIteratorPrototype, 'URLSearchParamsIterator', { defineIDLClass(URLSearchParamsIteratorPrototype, 'URLSearchParams Iterator', {
next() { next() {
if (!this || if (!this ||
Object.getPrototypeOf(this) !== URLSearchParamsIteratorPrototype) { Object.getPrototypeOf(this) !== URLSearchParamsIteratorPrototype) {

12
test/parallel/test-whatwg-url-searchparams-inspect.js
View File

@ -10,20 +10,20 @@ const sp = new URLSearchParams('?a=a&b=b&b=c');
assert.strictEqual(util.inspect(sp), assert.strictEqual(util.inspect(sp),
"URLSearchParams { 'a' => 'a', 'b' => 'b', 'b' => 'c' }"); "URLSearchParams { 'a' => 'a', 'b' => 'b', 'b' => 'c' }");
assert.strictEqual(util.inspect(sp.keys()), assert.strictEqual(util.inspect(sp.keys()),
"URLSearchParamsIterator { 'a', 'b', 'b' }"); "URLSearchParams Iterator { 'a', 'b', 'b' }");
assert.strictEqual(util.inspect(sp.values()), assert.strictEqual(util.inspect(sp.values()),
"URLSearchParamsIterator { 'a', 'b', 'c' }"); "URLSearchParams Iterator { 'a', 'b', 'c' }");
assert.strictEqual(util.inspect(sp.keys(), { breakLength: 1 }), assert.strictEqual(util.inspect(sp.keys(), { breakLength: 1 }),
"URLSearchParamsIterator {\n 'a',\n 'b',\n 'b' }"); "URLSearchParams Iterator {\n 'a',\n 'b',\n 'b' }");
const iterator = sp.entries(); const iterator = sp.entries();
assert.strictEqual(util.inspect(iterator), assert.strictEqual(util.inspect(iterator),
"URLSearchParamsIterator { [ 'a', 'a' ], [ 'b', 'b' ], " + "URLSearchParams Iterator { [ 'a', 'a' ], [ 'b', 'b' ], " +
"[ 'b', 'c' ] }"); "[ 'b', 'c' ] }");
iterator.next(); iterator.next();
assert.strictEqual(util.inspect(iterator), assert.strictEqual(util.inspect(iterator),
"URLSearchParamsIterator { [ 'b', 'b' ], [ 'b', 'c' ] }"); "URLSearchParams Iterator { [ 'b', 'b' ], [ 'b', 'c' ] }");
iterator.next(); iterator.next();
iterator.next(); iterator.next();
assert.strictEqual(util.inspect(iterator), assert.strictEqual(util.inspect(iterator),
'URLSearchParamsIterator { }'); 'URLSearchParams Iterator { }');

4
test/parallel/test-whatwg-url-tostringtag.js
View File

@ -14,13 +14,13 @@ const spIterator = sp.entries();
const test = [ const test = [
[url, 'URL'], [url, 'URL'],
[sp, 'URLSearchParams'], [sp, 'URLSearchParams'],
[spIterator, 'URLSearchParamsIterator'], [spIterator, 'URLSearchParams Iterator'],
// Web IDL spec says we have to return 'URLPrototype', but it is too // Web IDL spec says we have to return 'URLPrototype', but it is too
// expensive to implement; therefore, use Chrome's behavior for now, until // expensive to implement; therefore, use Chrome's behavior for now, until
// spec is changed. // spec is changed.
[Object.getPrototypeOf(url), 'URL'], [Object.getPrototypeOf(url), 'URL'],
[Object.getPrototypeOf(sp), 'URLSearchParams'], [Object.getPrototypeOf(sp), 'URLSearchParams'],
[Object.getPrototypeOf(spIterator), 'URLSearchParamsIterator'], [Object.getPrototypeOf(spIterator), 'URLSearchParams Iterator'],
]; ];
test.forEach(([obj, expected]) => { test.forEach(([obj, expected]) => {