1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactored test-crypto-random.js

Browse Source 
Replaced `var` by `const` for constant variables, enforced
strict equality check, and replaced custom callback execution
check by `common.mustCall`.

PR-URL: https://github.com/nodejs/node/pull/8632
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
This commit is contained in:
Tobias Kahse 2016-09-17 15:15:13 +02:00 committed by Ilkka Myller
parent 9fb59dfa39
commit 48142bcf4f
1 changed files with 6 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
test/parallel/test-crypto-random.js
View File

@ -1,12 +1,12 @@
'use strict'; 'use strict';
var common = require('../common'); const common = require('../common');
var assert = require('assert'); const assert = require('assert');
if (!common.hasCrypto) { if (!common.hasCrypto) {
common.skip('missing crypto'); common.skip('missing crypto');
return; return;
} }
var crypto = require('crypto'); const crypto = require('crypto');
crypto.DEFAULT_ENCODING = 'buffer'; crypto.DEFAULT_ENCODING = 'buffer';
@ -29,27 +29,14 @@ process.setMaxListeners(256);
}); });
[0, 1, 2, 4, 16, 256, 1024].forEach(function(len) { [0, 1, 2, 4, 16, 256, 1024].forEach(function(len) {
f(len, checkCall(function(ex, buf) { f(len, common.mustCall(function(ex, buf) {
assert.equal(null, ex); assert.strictEqual(null, ex);
assert.equal(len, buf.length); assert.strictEqual(len, buf.length);
assert.ok(Buffer.isBuffer(buf)); assert.ok(Buffer.isBuffer(buf));
})); }));
}); });
}); });
// assert that the callback is indeed called
function checkCall(cb, desc) {
var called_ = false;
process.on('exit', function() {
assert.equal(true, called_, desc || ('callback not called: ' + cb));
});
return function() {
return called_ = true, cb.apply(cb, Array.prototype.slice.call(arguments));
};
}
// #5126, "FATAL ERROR: v8::Object::SetIndexedPropertiesToExternalArrayData() // #5126, "FATAL ERROR: v8::Object::SetIndexedPropertiesToExternalArrayData()
// length exceeds max acceptable value" // length exceeds max acceptable value"
assert.throws(function() { assert.throws(function() {