1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

build: tidy up comments in create_expfile.sh

Browse Source 
Fixes spelling, adds punctuation and rewords some sentences for
readability in the comments of `tools/create_expfile.sh`.

PR-URL: https://github.com/nodejs/node/pull/26220
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Richard Lau 2019-02-20 10:34:05 -05:00
parent 3d4db3a7bf
commit 4804a18812
1 changed files with 27 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

53
tools/create_expfile.sh
View File

@ -1,44 +1,45 @@
#!/bin/sh #!/bin/sh
# This script writes out all the exported symbols to a file # Writes out all of the exported symbols to a file.
# AIX needs this as sybmols are not exported by an # This is needed on AIX as symbols are not exported
# executable by default and we need to list # by an executable by default and need to be listed
# them specifically in order to export them # specifically for export so that they can be used
# so that they can be used by native add-ons # by native add-ons.
# #
# The raw symbol data is objtained by using nm on # The raw symbol data is obtained by using nm on
# the .a files which make up the node executable # the .a files which make up the node executable.
# #
# -Xany makes sure we get symbols on both # -Xany processes symbols for both 32-bit and
# 32 bit and 64 bit as by default we'd only get those # 64-bit (the default is for 32-bit only).
# for 32 bit
# #
# -g selects only exported symbols # -g selects only exported symbols.
# #
# -C, -B and -p ensure the output is in a format we # -C, -B and -p ensure that the output is in a
# can easily parse and convert into the symbol we need # format that can be easily parsed and converted
# into the required symbol.
# #
# -C suppresses the demangling of C++ names # -C suppresses the demangling of C++ names.
# -B gives us output in BSD format # -B writes the output in BSD format.
# -p displays the info in a standard portable output format # -p displays the info in a standard portable
# output format.
# #
# We only include symbols if they are of the # Only include symbols if they are of the following
# following types and don't start with a dot. # types and don't start with a dot.
# #
# T - Global text symbol # T - Global text symbol.
# D - Global data symbol # D - Global data symbol.
# B - Gobal bss symbol. # B - Global bss symbol.
# #
# the final sort allows us to remove any duplicates # The final sort allows removal of any duplicates.
# #
# We need to exclude gtest libraries as they are not # Symbols for the gtest libraries are excluded as
# linked into the node executable # they are not linked into the node executable.
# #
echo "Searching $1 to write out expfile to $2" echo "Searching $1 to write out expfile to $2"
# this special sequence must be at the start of the exp file # This special sequence must be at the start of the exp file.
echo "#!." > $2.tmp echo "#!." > $2.tmp
# pull the symbols from the .a files # Pull the symbols from the .a files.
find $1 -name "*.a" | grep -v gtest \ find $1 -name "*.a" | grep -v gtest \
| xargs nm -Xany -BCpg \ | xargs nm -Xany -BCpg \
| awk '{ | awk '{