1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

src: remove util-inl.h include in node.h

Browse Source 
`node.h` may only include public APIs, which `util-inl.h` is not.
There does not seem to be any reason for including it, so remove it,
because otherwise native addon compilation is broken due to us not
shipping the `util-inl.h` header.

Refs: https://github.com/nodejs/node/pull/27631
Fixes: https://github.com/nodejs/node/issues/27803

PR-URL: https://github.com/nodejs/node/pull/27804
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This commit is contained in:
Anna Henningsen 2019-05-21 21:46:19 +02:00
parent b046bd1935
commit 47c5c3da86
No known key found for this signature in database
GPG Key ID: 9C63F3A6CD2AD8F9
1 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/node.h
View File

@ -103,14 +103,6 @@
# endif
#endif
#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
// Internally, do not include util-inl.h into files unless they need it's
// inline definitions.
#else
// Externally, it must be included for backwards API compatibility.
# include <util-inl.h>
#endif
// Forward-declare libuv loop
struct uv_loop_s;