1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix order of values in test assertions

Browse Source 
Have actual first, expected second.

PR-URL: https://github.com/nodejs/node/pull/23450
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This commit is contained in:
Jared Haines 2018-10-12 09:17:17 -07:00 committed by Rich Trott
parent f0c5c962ce
commit 478fe0aaff
1 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
test/parallel/test-http-server.js
View File

@ -37,23 +37,23 @@ const server = http.createServer(function(req, res) {
req.id = request_number++;
if (req.id === 0) {
assert.strictEqual('GET', req.method);
assert.strictEqual('/hello', url.parse(req.url).pathname);
assert.strictEqual('world', qs.parse(url.parse(req.url).query).hello);
assert.strictEqual('b==ar', qs.parse(url.parse(req.url).query).foo);
assert.strictEqual(req.method, 'GET');
assert.strictEqual(url.parse(req.url).pathname, '/hello');
assert.strictEqual(qs.parse(url.parse(req.url).query).hello, 'world');
assert.strictEqual(qs.parse(url.parse(req.url).query).foo, 'b==ar');
}
if (req.id === 1) {
assert.strictEqual('POST', req.method);
assert.strictEqual('/quit', url.parse(req.url).pathname);
assert.strictEqual(req.method, 'POST');
assert.strictEqual(url.parse(req.url).pathname, '/quit');
}
if (req.id === 2) {
assert.strictEqual('foo', req.headers['x-x']);
assert.strictEqual(req.headers['x-x'], 'foo');
}
if (req.id === 3) {
assert.strictEqual('bar', req.headers['x-x']);
assert.strictEqual(req.headers['x-x'], 'bar');
this.close();
}
@ -112,8 +112,8 @@ server.on('listening', function() {
});
process.on('exit', function() {
assert.strictEqual(4, request_number);
assert.strictEqual(4, requests_sent);
assert.strictEqual(request_number, 4);
assert.strictEqual(requests_sent, 4);
const hello = new RegExp('/hello');
assert.ok(hello.test(server_response));
@ -121,5 +121,5 @@ process.on('exit', function() {
const quit = new RegExp('/quit');
assert.ok(quit.test(server_response));
assert.strictEqual(true, client_got_eof);
assert.strictEqual(client_got_eof, true);
});