test,benchmark,doc: enable dot-notation rule
This enables the eslint dot-notation rule for all code instead of only in /lib. PR-URL: https://github.com/nodejs/node/pull/18749 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matheus Marchini <matheus@sthima.com>
This commit is contained in:
parent
36386dc4e3
commit
463d1a490f
@ -47,6 +47,7 @@ rules:
|
|||||||
accessor-pairs: error
|
accessor-pairs: error
|
||||||
array-callback-return: error
|
array-callback-return: error
|
||||||
dot-location: [error, property]
|
dot-location: [error, property]
|
||||||
|
dot-notation: error
|
||||||
eqeqeq: [error, smart]
|
eqeqeq: [error, smart]
|
||||||
no-fallthrough: error
|
no-fallthrough: error
|
||||||
no-global-assign: error
|
no-global-assign: error
|
||||||
|
@ -1,5 +1,7 @@
|
|||||||
'use strict';
|
'use strict';
|
||||||
|
|
||||||
|
/* eslint-disable dot-notation */
|
||||||
|
|
||||||
const common = require('../common.js');
|
const common = require('../common.js');
|
||||||
|
|
||||||
const bench = common.createBenchmark(main, {
|
const bench = common.createBenchmark(main, {
|
||||||
|
@ -1220,7 +1220,7 @@ const server = http2.createServer();
|
|||||||
server.on('stream', (stream) => {
|
server.on('stream', (stream) => {
|
||||||
stream.respond({ ':status': 200 }, {
|
stream.respond({ ':status': 200 }, {
|
||||||
getTrailers(trailers) {
|
getTrailers(trailers) {
|
||||||
trailers['ABC'] = 'some value to send';
|
trailers.ABC = 'some value to send';
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
stream.end('some data');
|
stream.end('some data');
|
||||||
@ -1303,7 +1303,7 @@ server.on('stream', (stream) => {
|
|||||||
};
|
};
|
||||||
stream.respondWithFD(fd, headers, {
|
stream.respondWithFD(fd, headers, {
|
||||||
getTrailers(trailers) {
|
getTrailers(trailers) {
|
||||||
trailers['ABC'] = 'some value to send';
|
trailers.ABC = 'some value to send';
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
@ -1410,7 +1410,7 @@ const http2 = require('http2');
|
|||||||
const server = http2.createServer();
|
const server = http2.createServer();
|
||||||
server.on('stream', (stream) => {
|
server.on('stream', (stream) => {
|
||||||
function getTrailers(trailers) {
|
function getTrailers(trailers) {
|
||||||
trailers['ABC'] = 'some value to send';
|
trailers.ABC = 'some value to send';
|
||||||
}
|
}
|
||||||
stream.respondWithFile('/some/file',
|
stream.respondWithFile('/some/file',
|
||||||
{ 'content-type': 'text/plain' },
|
{ 'content-type': 'text/plain' },
|
||||||
|
@ -1,6 +1,4 @@
|
|||||||
rules:
|
rules:
|
||||||
dot-notation: error
|
|
||||||
|
|
||||||
# Custom rules in tools/eslint-rules
|
# Custom rules in tools/eslint-rules
|
||||||
require-buffer: error
|
require-buffer: error
|
||||||
buffer-constructor: error
|
buffer-constructor: error
|
||||||
|
@ -8,11 +8,10 @@ const test_symbol = require(`./build/${common.buildType}/test_symbol`);
|
|||||||
const sym = test_symbol.New('test');
|
const sym = test_symbol.New('test');
|
||||||
assert.strictEqual(sym.toString(), 'Symbol(test)');
|
assert.strictEqual(sym.toString(), 'Symbol(test)');
|
||||||
|
|
||||||
|
|
||||||
const myObj = {};
|
const myObj = {};
|
||||||
const fooSym = test_symbol.New('foo');
|
const fooSym = test_symbol.New('foo');
|
||||||
const otherSym = test_symbol.New('bar');
|
const otherSym = test_symbol.New('bar');
|
||||||
myObj['foo'] = 'bar';
|
myObj.foo = 'bar';
|
||||||
myObj[fooSym] = 'baz';
|
myObj[fooSym] = 'baz';
|
||||||
myObj[otherSym] = 'bing';
|
myObj[otherSym] = 'bing';
|
||||||
assert.strictEqual(myObj.foo, 'bar');
|
assert.strictEqual(myObj.foo, 'bar');
|
||||||
|
@ -7,7 +7,7 @@ const test_symbol = require(`./build/${common.buildType}/test_symbol`);
|
|||||||
|
|
||||||
const fooSym = test_symbol.New('foo');
|
const fooSym = test_symbol.New('foo');
|
||||||
const myObj = {};
|
const myObj = {};
|
||||||
myObj['foo'] = 'bar';
|
myObj.foo = 'bar';
|
||||||
myObj[fooSym] = 'baz';
|
myObj[fooSym] = 'baz';
|
||||||
Object.keys(myObj); // -> [ 'foo' ]
|
Object.keys(myObj); // -> [ 'foo' ]
|
||||||
Object.getOwnPropertyNames(myObj); // -> [ 'foo' ]
|
Object.getOwnPropertyNames(myObj); // -> [ 'foo' ]
|
||||||
|
@ -502,7 +502,7 @@ exports.canCreateSymLink = function() {
|
|||||||
// whoami.exe needs to be the one from System32
|
// whoami.exe needs to be the one from System32
|
||||||
// If unix tools are in the path, they can shadow the one we want,
|
// If unix tools are in the path, they can shadow the one we want,
|
||||||
// so use the full path while executing whoami
|
// so use the full path while executing whoami
|
||||||
const whoamiPath = path.join(process.env['SystemRoot'],
|
const whoamiPath = path.join(process.env.SystemRoot,
|
||||||
'System32', 'whoami.exe');
|
'System32', 'whoami.exe');
|
||||||
|
|
||||||
try {
|
try {
|
||||||
|
@ -168,9 +168,7 @@ class InspectorSession {
|
|||||||
reject(message.error);
|
reject(message.error);
|
||||||
} else {
|
} else {
|
||||||
if (message.method === 'Debugger.scriptParsed') {
|
if (message.method === 'Debugger.scriptParsed') {
|
||||||
const script = message['params'];
|
const { scriptId, url } = message.params;
|
||||||
const scriptId = script['scriptId'];
|
|
||||||
const url = script['url'];
|
|
||||||
this._scriptsIdsByUrl.set(scriptId, url);
|
this._scriptsIdsByUrl.set(scriptId, url);
|
||||||
const fileUrl = url.startsWith('file:') ?
|
const fileUrl = url.startsWith('file:') ?
|
||||||
url : getURLFromFilePath(url).toString();
|
url : getURLFromFilePath(url).toString();
|
||||||
@ -192,12 +190,12 @@ class InspectorSession {
|
|||||||
|
|
||||||
_sendMessage(message) {
|
_sendMessage(message) {
|
||||||
const msg = JSON.parse(JSON.stringify(message)); // Clone!
|
const msg = JSON.parse(JSON.stringify(message)); // Clone!
|
||||||
msg['id'] = this._nextId++;
|
msg.id = this._nextId++;
|
||||||
if (DEBUG)
|
if (DEBUG)
|
||||||
console.log('[sent]', JSON.stringify(msg));
|
console.log('[sent]', JSON.stringify(msg));
|
||||||
|
|
||||||
const responsePromise = new Promise((resolve, reject) => {
|
const responsePromise = new Promise((resolve, reject) => {
|
||||||
this._commandResponsePromises.set(msg['id'], { resolve, reject });
|
this._commandResponsePromises.set(msg.id, { resolve, reject });
|
||||||
});
|
});
|
||||||
|
|
||||||
return new Promise(
|
return new Promise(
|
||||||
@ -243,14 +241,14 @@ class InspectorSession {
|
|||||||
}
|
}
|
||||||
|
|
||||||
_isBreakOnLineNotification(message, line, expectedScriptPath) {
|
_isBreakOnLineNotification(message, line, expectedScriptPath) {
|
||||||
if ('Debugger.paused' === message['method']) {
|
if ('Debugger.paused' === message.method) {
|
||||||
const callFrame = message['params']['callFrames'][0];
|
const callFrame = message.params.callFrames[0];
|
||||||
const location = callFrame['location'];
|
const location = callFrame.location;
|
||||||
const scriptPath = this._scriptsIdsByUrl.get(location['scriptId']);
|
const scriptPath = this._scriptsIdsByUrl.get(location.scriptId);
|
||||||
assert.strictEqual(scriptPath.toString(),
|
assert.strictEqual(scriptPath.toString(),
|
||||||
expectedScriptPath.toString(),
|
expectedScriptPath.toString(),
|
||||||
`${scriptPath} !== ${expectedScriptPath}`);
|
`${scriptPath} !== ${expectedScriptPath}`);
|
||||||
assert.strictEqual(line, location['lineNumber']);
|
assert.strictEqual(line, location.lineNumber);
|
||||||
return true;
|
return true;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@ -266,12 +264,12 @@ class InspectorSession {
|
|||||||
_matchesConsoleOutputNotification(notification, type, values) {
|
_matchesConsoleOutputNotification(notification, type, values) {
|
||||||
if (!Array.isArray(values))
|
if (!Array.isArray(values))
|
||||||
values = [ values ];
|
values = [ values ];
|
||||||
if ('Runtime.consoleAPICalled' === notification['method']) {
|
if ('Runtime.consoleAPICalled' === notification.method) {
|
||||||
const params = notification['params'];
|
const params = notification.params;
|
||||||
if (params['type'] === type) {
|
if (params.type === type) {
|
||||||
let i = 0;
|
let i = 0;
|
||||||
for (const value of params['args']) {
|
for (const value of params.args) {
|
||||||
if (value['value'] !== values[i++])
|
if (value.value !== values[i++])
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
return i === values.length;
|
return i === values.length;
|
||||||
@ -392,7 +390,7 @@ class NodeInstance {
|
|||||||
|
|
||||||
async sendUpgradeRequest() {
|
async sendUpgradeRequest() {
|
||||||
const response = await this.httpGet(null, '/json/list');
|
const response = await this.httpGet(null, '/json/list');
|
||||||
const devtoolsUrl = response[0]['webSocketDebuggerUrl'];
|
const devtoolsUrl = response[0].webSocketDebuggerUrl;
|
||||||
const port = await this.portPromise;
|
const port = await this.portPromise;
|
||||||
return http.get({
|
return http.get({
|
||||||
port,
|
port,
|
||||||
|
@ -31,8 +31,8 @@ const cluster = require('cluster');
|
|||||||
|
|
||||||
if (cluster.isWorker) {
|
if (cluster.isWorker) {
|
||||||
const result = cluster.worker.send({
|
const result = cluster.worker.send({
|
||||||
prop: process.env['cluster_test_prop'],
|
prop: process.env.cluster_test_prop,
|
||||||
overwrite: process.env['cluster_test_overwrite']
|
overwrite: process.env.cluster_test_overwrite
|
||||||
});
|
});
|
||||||
|
|
||||||
assert.strictEqual(result, true);
|
assert.strictEqual(result, true);
|
||||||
@ -45,7 +45,7 @@ if (cluster.isWorker) {
|
|||||||
|
|
||||||
// To check that the cluster extend on the process.env we will overwrite a
|
// To check that the cluster extend on the process.env we will overwrite a
|
||||||
// property
|
// property
|
||||||
process.env['cluster_test_overwrite'] = 'old';
|
process.env.cluster_test_overwrite = 'old';
|
||||||
|
|
||||||
// Fork worker
|
// Fork worker
|
||||||
const worker = cluster.fork({
|
const worker = cluster.fork({
|
||||||
|
@ -87,13 +87,13 @@ const wikipedia = [
|
|||||||
];
|
];
|
||||||
|
|
||||||
for (let i = 0, l = wikipedia.length; i < l; i++) {
|
for (let i = 0, l = wikipedia.length; i < l; i++) {
|
||||||
for (const hash in wikipedia[i]['hmac']) {
|
for (const hash in wikipedia[i].hmac) {
|
||||||
// FIPS does not support MD5.
|
// FIPS does not support MD5.
|
||||||
if (common.hasFipsCrypto && hash === 'md5')
|
if (common.hasFipsCrypto && hash === 'md5')
|
||||||
continue;
|
continue;
|
||||||
const expected = wikipedia[i]['hmac'][hash];
|
const expected = wikipedia[i].hmac[hash];
|
||||||
const actual = crypto.createHmac(hash, wikipedia[i]['key'])
|
const actual = crypto.createHmac(hash, wikipedia[i].key)
|
||||||
.update(wikipedia[i]['data'])
|
.update(wikipedia[i].data)
|
||||||
.digest('hex');
|
.digest('hex');
|
||||||
assert.strictEqual(
|
assert.strictEqual(
|
||||||
actual,
|
actual,
|
||||||
@ -252,18 +252,18 @@ const rfc4231 = [
|
|||||||
];
|
];
|
||||||
|
|
||||||
for (let i = 0, l = rfc4231.length; i < l; i++) {
|
for (let i = 0, l = rfc4231.length; i < l; i++) {
|
||||||
for (const hash in rfc4231[i]['hmac']) {
|
for (const hash in rfc4231[i].hmac) {
|
||||||
const str = crypto.createHmac(hash, rfc4231[i].key);
|
const str = crypto.createHmac(hash, rfc4231[i].key);
|
||||||
str.end(rfc4231[i].data);
|
str.end(rfc4231[i].data);
|
||||||
let strRes = str.read().toString('hex');
|
let strRes = str.read().toString('hex');
|
||||||
let actual = crypto.createHmac(hash, rfc4231[i]['key'])
|
let actual = crypto.createHmac(hash, rfc4231[i].key)
|
||||||
.update(rfc4231[i]['data'])
|
.update(rfc4231[i].data)
|
||||||
.digest('hex');
|
.digest('hex');
|
||||||
if (rfc4231[i]['truncate']) {
|
if (rfc4231[i].truncate) {
|
||||||
actual = actual.substr(0, 32); // first 128 bits == 32 hex chars
|
actual = actual.substr(0, 32); // first 128 bits == 32 hex chars
|
||||||
strRes = strRes.substr(0, 32);
|
strRes = strRes.substr(0, 32);
|
||||||
}
|
}
|
||||||
const expected = rfc4231[i]['hmac'][hash];
|
const expected = rfc4231[i].hmac[hash];
|
||||||
assert.strictEqual(
|
assert.strictEqual(
|
||||||
actual,
|
actual,
|
||||||
expected,
|
expected,
|
||||||
@ -384,10 +384,10 @@ const rfc2202_sha1 = [
|
|||||||
|
|
||||||
if (!common.hasFipsCrypto) {
|
if (!common.hasFipsCrypto) {
|
||||||
for (let i = 0, l = rfc2202_md5.length; i < l; i++) {
|
for (let i = 0, l = rfc2202_md5.length; i < l; i++) {
|
||||||
const actual = crypto.createHmac('md5', rfc2202_md5[i]['key'])
|
const actual = crypto.createHmac('md5', rfc2202_md5[i].key)
|
||||||
.update(rfc2202_md5[i]['data'])
|
.update(rfc2202_md5[i].data)
|
||||||
.digest('hex');
|
.digest('hex');
|
||||||
const expected = rfc2202_md5[i]['hmac'];
|
const expected = rfc2202_md5[i].hmac;
|
||||||
assert.strictEqual(
|
assert.strictEqual(
|
||||||
actual,
|
actual,
|
||||||
expected,
|
expected,
|
||||||
@ -396,10 +396,10 @@ if (!common.hasFipsCrypto) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
for (let i = 0, l = rfc2202_sha1.length; i < l; i++) {
|
for (let i = 0, l = rfc2202_sha1.length; i < l; i++) {
|
||||||
const actual = crypto.createHmac('sha1', rfc2202_sha1[i]['key'])
|
const actual = crypto.createHmac('sha1', rfc2202_sha1[i].key)
|
||||||
.update(rfc2202_sha1[i]['data'])
|
.update(rfc2202_sha1[i].data)
|
||||||
.digest('hex');
|
.digest('hex');
|
||||||
const expected = rfc2202_sha1[i]['hmac'];
|
const expected = rfc2202_sha1[i].hmac;
|
||||||
assert.strictEqual(
|
assert.strictEqual(
|
||||||
actual,
|
actual,
|
||||||
expected,
|
expected,
|
||||||
|
@ -32,9 +32,9 @@ const events = require('events');
|
|||||||
for (let i = 0; i < 10; i++) {
|
for (let i = 0; i < 10; i++) {
|
||||||
e.on('default', common.mustNotCall());
|
e.on('default', common.mustNotCall());
|
||||||
}
|
}
|
||||||
assert.ok(!e._events['default'].hasOwnProperty('warned'));
|
assert.ok(!e._events.default.hasOwnProperty('warned'));
|
||||||
e.on('default', common.mustNotCall());
|
e.on('default', common.mustNotCall());
|
||||||
assert.ok(e._events['default'].warned);
|
assert.ok(e._events.default.warned);
|
||||||
|
|
||||||
// symbol
|
// symbol
|
||||||
const symbol = Symbol('symbol');
|
const symbol = Symbol('symbol');
|
||||||
@ -49,9 +49,9 @@ const events = require('events');
|
|||||||
for (let i = 0; i < 5; i++) {
|
for (let i = 0; i < 5; i++) {
|
||||||
e.on('specific', common.mustNotCall());
|
e.on('specific', common.mustNotCall());
|
||||||
}
|
}
|
||||||
assert.ok(!e._events['specific'].hasOwnProperty('warned'));
|
assert.ok(!e._events.specific.hasOwnProperty('warned'));
|
||||||
e.on('specific', common.mustNotCall());
|
e.on('specific', common.mustNotCall());
|
||||||
assert.ok(e._events['specific'].warned);
|
assert.ok(e._events.specific.warned);
|
||||||
|
|
||||||
// only one
|
// only one
|
||||||
e.setMaxListeners(1);
|
e.setMaxListeners(1);
|
||||||
@ -65,7 +65,7 @@ const events = require('events');
|
|||||||
for (let i = 0; i < 1000; i++) {
|
for (let i = 0; i < 1000; i++) {
|
||||||
e.on('unlimited', common.mustNotCall());
|
e.on('unlimited', common.mustNotCall());
|
||||||
}
|
}
|
||||||
assert.ok(!e._events['unlimited'].hasOwnProperty('warned'));
|
assert.ok(!e._events.unlimited.hasOwnProperty('warned'));
|
||||||
}
|
}
|
||||||
|
|
||||||
// process-wide
|
// process-wide
|
||||||
@ -76,16 +76,16 @@ const events = require('events');
|
|||||||
for (let i = 0; i < 42; ++i) {
|
for (let i = 0; i < 42; ++i) {
|
||||||
e.on('fortytwo', common.mustNotCall());
|
e.on('fortytwo', common.mustNotCall());
|
||||||
}
|
}
|
||||||
assert.ok(!e._events['fortytwo'].hasOwnProperty('warned'));
|
assert.ok(!e._events.fortytwo.hasOwnProperty('warned'));
|
||||||
e.on('fortytwo', common.mustNotCall());
|
e.on('fortytwo', common.mustNotCall());
|
||||||
assert.ok(e._events['fortytwo'].hasOwnProperty('warned'));
|
assert.ok(e._events.fortytwo.hasOwnProperty('warned'));
|
||||||
delete e._events['fortytwo'].warned;
|
delete e._events.fortytwo.warned;
|
||||||
|
|
||||||
events.EventEmitter.defaultMaxListeners = 44;
|
events.EventEmitter.defaultMaxListeners = 44;
|
||||||
e.on('fortytwo', common.mustNotCall());
|
e.on('fortytwo', common.mustNotCall());
|
||||||
assert.ok(!e._events['fortytwo'].hasOwnProperty('warned'));
|
assert.ok(!e._events.fortytwo.hasOwnProperty('warned'));
|
||||||
e.on('fortytwo', common.mustNotCall());
|
e.on('fortytwo', common.mustNotCall());
|
||||||
assert.ok(e._events['fortytwo'].hasOwnProperty('warned'));
|
assert.ok(e._events.fortytwo.hasOwnProperty('warned'));
|
||||||
}
|
}
|
||||||
|
|
||||||
// but _maxListeners still has precedence over defaultMaxListeners
|
// but _maxListeners still has precedence over defaultMaxListeners
|
||||||
@ -94,9 +94,9 @@ const events = require('events');
|
|||||||
const e = new events.EventEmitter();
|
const e = new events.EventEmitter();
|
||||||
e.setMaxListeners(1);
|
e.setMaxListeners(1);
|
||||||
e.on('uno', common.mustNotCall());
|
e.on('uno', common.mustNotCall());
|
||||||
assert.ok(!e._events['uno'].hasOwnProperty('warned'));
|
assert.ok(!e._events.uno.hasOwnProperty('warned'));
|
||||||
e.on('uno', common.mustNotCall());
|
e.on('uno', common.mustNotCall());
|
||||||
assert.ok(e._events['uno'].hasOwnProperty('warned'));
|
assert.ok(e._events.uno.hasOwnProperty('warned'));
|
||||||
|
|
||||||
// chainable
|
// chainable
|
||||||
assert.strictEqual(e, e.setMaxListeners(1));
|
assert.strictEqual(e, e.setMaxListeners(1));
|
||||||
|
@ -22,8 +22,8 @@ server.on('listening', common.mustCall(() => {
|
|||||||
assert.strictEqual(res.headers['x-date'], 'foo');
|
assert.strictEqual(res.headers['x-date'], 'foo');
|
||||||
assert.strictEqual(res.headers['x-connection'], 'bar');
|
assert.strictEqual(res.headers['x-connection'], 'bar');
|
||||||
assert.strictEqual(res.headers['x-content-length'], 'baz');
|
assert.strictEqual(res.headers['x-content-length'], 'baz');
|
||||||
assert(res.headers['date']);
|
assert(res.headers.date);
|
||||||
assert.strictEqual(res.headers['connection'], 'keep-alive');
|
assert.strictEqual(res.headers.connection, 'keep-alive');
|
||||||
assert.strictEqual(res.headers['content-length'], '0');
|
assert.strictEqual(res.headers['content-length'], '0');
|
||||||
server.close();
|
server.close();
|
||||||
agent.destroy();
|
agent.destroy();
|
||||||
|
@ -5,7 +5,7 @@ const http = require('http');
|
|||||||
|
|
||||||
const server = http.createServer();
|
const server = http.createServer();
|
||||||
server.on('request', function(req, res) {
|
server.on('request', function(req, res) {
|
||||||
assert.strictEqual(req.headers['foo'], 'bar');
|
assert.strictEqual(req.headers.foo, 'bar');
|
||||||
res.end('ok');
|
res.end('ok');
|
||||||
server.close();
|
server.close();
|
||||||
});
|
});
|
||||||
|
@ -20,7 +20,7 @@ server.listen(0, common.localhostIPv4, function() {
|
|||||||
req.end();
|
req.end();
|
||||||
|
|
||||||
function onResponse(res) {
|
function onResponse(res) {
|
||||||
assert.strictEqual(res.headers['foo'], 'bar');
|
assert.strictEqual(res.headers.foo, 'bar');
|
||||||
res.destroy();
|
res.destroy();
|
||||||
server.close();
|
server.close();
|
||||||
}
|
}
|
||||||
|
@ -50,7 +50,7 @@ const proxy = http.createServer(function(req, res) {
|
|||||||
|
|
||||||
console.error(`proxy res headers: ${JSON.stringify(proxy_res.headers)}`);
|
console.error(`proxy res headers: ${JSON.stringify(proxy_res.headers)}`);
|
||||||
|
|
||||||
assert.strictEqual('world', proxy_res.headers['hello']);
|
assert.strictEqual('world', proxy_res.headers.hello);
|
||||||
assert.strictEqual('text/plain', proxy_res.headers['content-type']);
|
assert.strictEqual('text/plain', proxy_res.headers['content-type']);
|
||||||
assert.deepStrictEqual(cookies, proxy_res.headers['set-cookie']);
|
assert.deepStrictEqual(cookies, proxy_res.headers['set-cookie']);
|
||||||
|
|
||||||
@ -81,7 +81,7 @@ function startReq() {
|
|||||||
console.error('got res');
|
console.error('got res');
|
||||||
assert.strictEqual(200, res.statusCode);
|
assert.strictEqual(200, res.statusCode);
|
||||||
|
|
||||||
assert.strictEqual('world', res.headers['hello']);
|
assert.strictEqual('world', res.headers.hello);
|
||||||
assert.strictEqual('text/plain', res.headers['content-type']);
|
assert.strictEqual('text/plain', res.headers['content-type']);
|
||||||
assert.deepStrictEqual(cookies, res.headers['set-cookie']);
|
assert.deepStrictEqual(cookies, res.headers['set-cookie']);
|
||||||
|
|
||||||
|
@ -38,7 +38,7 @@ const srv = http.createServer(function(req, res) {
|
|||||||
assert.strictEqual(req.headers['sec-websocket-protocol'], 'chat, share');
|
assert.strictEqual(req.headers['sec-websocket-protocol'], 'chat, share');
|
||||||
assert.strictEqual(req.headers['sec-websocket-extensions'],
|
assert.strictEqual(req.headers['sec-websocket-extensions'],
|
||||||
'foo; 1, bar; 2, baz');
|
'foo; 1, bar; 2, baz');
|
||||||
assert.strictEqual(req.headers['constructor'], 'foo, bar, baz');
|
assert.strictEqual(req.headers.constructor, 'foo, bar, baz');
|
||||||
|
|
||||||
res.writeHead(200, { 'Content-Type': 'text/plain' });
|
res.writeHead(200, { 'Content-Type': 'text/plain' });
|
||||||
res.end('EOF');
|
res.end('EOF');
|
||||||
|
@ -68,7 +68,7 @@ s.listen(0, common.mustCall(runTest));
|
|||||||
function runTest() {
|
function runTest() {
|
||||||
http.get({ port: this.address().port }, common.mustCall((response) => {
|
http.get({ port: this.address().port }, common.mustCall((response) => {
|
||||||
response.on('end', common.mustCall(() => {
|
response.on('end', common.mustCall(() => {
|
||||||
assert.strictEqual(response.headers['test'], '2');
|
assert.strictEqual(response.headers.test, '2');
|
||||||
assert(response.rawHeaders.includes('Test'));
|
assert(response.rawHeaders.includes('Test'));
|
||||||
s.close();
|
s.close();
|
||||||
}));
|
}));
|
||||||
|
@ -33,8 +33,8 @@ const server = http.Server(common.mustCall(function(req, res) {
|
|||||||
switch (req.url) {
|
switch (req.url) {
|
||||||
case '/hello':
|
case '/hello':
|
||||||
assert.strictEqual(req.method, 'GET');
|
assert.strictEqual(req.method, 'GET');
|
||||||
assert.strictEqual(req.headers['accept'], '*/*');
|
assert.strictEqual(req.headers.accept, '*/*');
|
||||||
assert.strictEqual(req.headers['foo'], 'bar');
|
assert.strictEqual(req.headers.foo, 'bar');
|
||||||
assert.strictEqual(req.headers.cookie, 'foo=bar; bar=baz; baz=quux');
|
assert.strictEqual(req.headers.cookie, 'foo=bar; bar=baz; baz=quux');
|
||||||
break;
|
break;
|
||||||
case '/there':
|
case '/there':
|
||||||
|
@ -11,7 +11,7 @@ const expectValue = 'meoww';
|
|||||||
const server = http2.createServer(common.mustNotCall());
|
const server = http2.createServer(common.mustNotCall());
|
||||||
|
|
||||||
server.once('checkExpectation', common.mustCall((req, res) => {
|
server.once('checkExpectation', common.mustCall((req, res) => {
|
||||||
assert.strictEqual(req.headers['expect'], expectValue);
|
assert.strictEqual(req.headers.expect, expectValue);
|
||||||
res.statusCode = 417;
|
res.statusCode = 417;
|
||||||
res.end();
|
res.end();
|
||||||
}));
|
}));
|
||||||
|
@ -77,7 +77,7 @@ server.listen(0, common.mustCall(() => {
|
|||||||
let actual = '';
|
let actual = '';
|
||||||
pushStream.on('push', common.mustCall((headers) => {
|
pushStream.on('push', common.mustCall((headers) => {
|
||||||
assert.strictEqual(headers[':status'], 200);
|
assert.strictEqual(headers[':status'], 200);
|
||||||
assert(headers['date']);
|
assert(headers.date);
|
||||||
}));
|
}));
|
||||||
pushStream.setEncoding('utf8');
|
pushStream.setEncoding('utf8');
|
||||||
pushStream.on('data', (chunk) => actual += chunk);
|
pushStream.on('data', (chunk) => actual += chunk);
|
||||||
@ -89,7 +89,7 @@ server.listen(0, common.mustCall(() => {
|
|||||||
|
|
||||||
req.on('response', common.mustCall((headers) => {
|
req.on('response', common.mustCall((headers) => {
|
||||||
assert.strictEqual(headers[':status'], 200);
|
assert.strictEqual(headers[':status'], 200);
|
||||||
assert(headers['date']);
|
assert(headers.date);
|
||||||
}));
|
}));
|
||||||
|
|
||||||
let actual = '';
|
let actual = '';
|
||||||
|
@ -62,7 +62,7 @@ function verifySecureSession(key, cert, ca, opts) {
|
|||||||
req.on('response', common.mustCall((headers) => {
|
req.on('response', common.mustCall((headers) => {
|
||||||
assert.strictEqual(headers[':status'], 200);
|
assert.strictEqual(headers[':status'], 200);
|
||||||
assert.strictEqual(headers['content-type'], 'application/json');
|
assert.strictEqual(headers['content-type'], 'application/json');
|
||||||
assert(headers['date']);
|
assert(headers.date);
|
||||||
}));
|
}));
|
||||||
|
|
||||||
let data = '';
|
let data = '';
|
||||||
|
@ -58,7 +58,7 @@ server.on('listening', common.mustCall(() => {
|
|||||||
assert.strictEqual(headers[':status'], 200, 'status code is set');
|
assert.strictEqual(headers[':status'], 200, 'status code is set');
|
||||||
assert.strictEqual(headers['content-type'], 'text/html',
|
assert.strictEqual(headers['content-type'], 'text/html',
|
||||||
'content type is set');
|
'content type is set');
|
||||||
assert(headers['date'], 'there is a date');
|
assert(headers.date);
|
||||||
}));
|
}));
|
||||||
|
|
||||||
let data = '';
|
let data = '';
|
||||||
|
@ -12,7 +12,7 @@ const src = Object.create(null);
|
|||||||
src['www-authenticate'] = 'foo';
|
src['www-authenticate'] = 'foo';
|
||||||
src['WWW-Authenticate'] = 'bar';
|
src['WWW-Authenticate'] = 'bar';
|
||||||
src['WWW-AUTHENTICATE'] = 'baz';
|
src['WWW-AUTHENTICATE'] = 'baz';
|
||||||
src['test'] = 'foo, bar, baz';
|
src.test = 'foo, bar, baz';
|
||||||
|
|
||||||
server.on('stream', common.mustCall((stream, headers, flags, rawHeaders) => {
|
server.on('stream', common.mustCall((stream, headers, flags, rawHeaders) => {
|
||||||
const expected = [
|
const expected = [
|
||||||
|
@ -24,21 +24,21 @@ src.constructor = 'foo';
|
|||||||
src.Constructor = 'bar';
|
src.Constructor = 'bar';
|
||||||
src.CONSTRUCTOR = 'baz';
|
src.CONSTRUCTOR = 'baz';
|
||||||
// eslint-disable-next-line no-proto
|
// eslint-disable-next-line no-proto
|
||||||
src['__proto__'] = 'foo';
|
src.__proto__ = 'foo';
|
||||||
src['__PROTO__'] = 'bar';
|
src.__PROTO__ = 'bar';
|
||||||
src['__Proto__'] = 'baz';
|
src.__Proto__ = 'baz';
|
||||||
|
|
||||||
function checkHeaders(headers) {
|
function checkHeaders(headers) {
|
||||||
assert.deepStrictEqual(headers['accept'],
|
assert.deepStrictEqual(headers.accept,
|
||||||
'abc, def, ghijklmnop');
|
'abc, def, ghijklmnop');
|
||||||
assert.deepStrictEqual(headers['www-authenticate'],
|
assert.deepStrictEqual(headers['www-authenticate'],
|
||||||
'foo, bar, baz');
|
'foo, bar, baz');
|
||||||
assert.deepStrictEqual(headers['proxy-authenticate'],
|
assert.deepStrictEqual(headers['proxy-authenticate'],
|
||||||
'foo, bar, baz');
|
'foo, bar, baz');
|
||||||
assert.deepStrictEqual(headers['x-foo'], 'foo, bar, baz');
|
assert.deepStrictEqual(headers['x-foo'], 'foo, bar, baz');
|
||||||
assert.deepStrictEqual(headers['constructor'], 'foo, bar, baz');
|
assert.deepStrictEqual(headers.constructor, 'foo, bar, baz');
|
||||||
// eslint-disable-next-line no-proto
|
// eslint-disable-next-line no-proto
|
||||||
assert.deepStrictEqual(headers['__proto__'], 'foo, bar, baz');
|
assert.deepStrictEqual(headers.__proto__, 'foo, bar, baz');
|
||||||
}
|
}
|
||||||
|
|
||||||
server.on('stream', common.mustCall((stream, headers) => {
|
server.on('stream', common.mustCall((stream, headers) => {
|
||||||
|
@ -26,7 +26,7 @@ const tests = [
|
|||||||
|
|
||||||
const server = http2.createServer();
|
const server = http2.createServer();
|
||||||
server.on('stream', (stream, headers) => {
|
server.on('stream', (stream, headers) => {
|
||||||
stream.close(headers['rstcode'] | 0);
|
stream.close(headers.rstcode | 0);
|
||||||
});
|
});
|
||||||
|
|
||||||
server.listen(0, common.mustCall(() => {
|
server.listen(0, common.mustCall(() => {
|
||||||
|
@ -20,7 +20,7 @@ server.listen(0, common.mustCall(() => {
|
|||||||
const req = client.request(headers);
|
const req = client.request(headers);
|
||||||
req.setEncoding('utf8');
|
req.setEncoding('utf8');
|
||||||
req.on('response', common.mustCall(function(headers) {
|
req.on('response', common.mustCall(function(headers) {
|
||||||
assert.strictEqual(headers['foobar'], 'baz');
|
assert.strictEqual(headers.foobar, 'baz');
|
||||||
assert.strictEqual(headers['x-powered-by'], 'node-test');
|
assert.strictEqual(headers['x-powered-by'], 'node-test');
|
||||||
}));
|
}));
|
||||||
|
|
||||||
|
@ -112,11 +112,11 @@ const server = https.createServer(options, function(req, res) {
|
|||||||
|
|
||||||
process.on('exit', function() {
|
process.on('exit', function() {
|
||||||
assert.strictEqual(serverRequests, 6);
|
assert.strictEqual(serverRequests, 6);
|
||||||
assert.strictEqual(clientSessions['first'].toString('hex'),
|
assert.strictEqual(clientSessions.first.toString('hex'),
|
||||||
clientSessions['first-reuse'].toString('hex'));
|
clientSessions['first-reuse'].toString('hex'));
|
||||||
assert.notStrictEqual(clientSessions['first'].toString('hex'),
|
assert.notStrictEqual(clientSessions.first.toString('hex'),
|
||||||
clientSessions['cipher-change'].toString('hex'));
|
clientSessions['cipher-change'].toString('hex'));
|
||||||
assert.notStrictEqual(clientSessions['first'].toString('hex'),
|
assert.notStrictEqual(clientSessions.first.toString('hex'),
|
||||||
clientSessions['before-drop'].toString('hex'));
|
clientSessions['before-drop'].toString('hex'));
|
||||||
assert.notStrictEqual(clientSessions['cipher-change'].toString('hex'),
|
assert.notStrictEqual(clientSessions['cipher-change'].toString('hex'),
|
||||||
clientSessions['before-drop'].toString('hex'));
|
clientSessions['before-drop'].toString('hex'));
|
||||||
|
@ -17,9 +17,9 @@ function assertNoUrlsWhileConnected(response) {
|
|||||||
function assertScopeValues({ result }, expected) {
|
function assertScopeValues({ result }, expected) {
|
||||||
const unmatched = new Set(Object.keys(expected));
|
const unmatched = new Set(Object.keys(expected));
|
||||||
for (const actual of result) {
|
for (const actual of result) {
|
||||||
const value = expected[actual['name']];
|
const value = expected[actual.name];
|
||||||
assert.strictEqual(actual['value']['value'], value);
|
assert.strictEqual(actual.value.value, value);
|
||||||
unmatched.delete(actual['name']);
|
unmatched.delete(actual.name);
|
||||||
}
|
}
|
||||||
assert.deepStrictEqual(Array.from(unmatched.values()), []);
|
assert.deepStrictEqual(Array.from(unmatched.values()), []);
|
||||||
}
|
}
|
||||||
@ -93,14 +93,14 @@ async function testBreakpoint(session) {
|
|||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
assert.strictEqual(result['value'], 1002);
|
assert.strictEqual(result.value, 1002);
|
||||||
|
|
||||||
result = (await session.send({
|
result = (await session.send({
|
||||||
'method': 'Runtime.evaluate', 'params': {
|
'method': 'Runtime.evaluate', 'params': {
|
||||||
'expression': '5 * 5'
|
'expression': '5 * 5'
|
||||||
}
|
}
|
||||||
})).result;
|
})).result;
|
||||||
assert.strictEqual(result['value'], 25);
|
assert.strictEqual(result.value, 25);
|
||||||
}
|
}
|
||||||
|
|
||||||
async function runTest() {
|
async function runTest() {
|
||||||
|
@ -7,8 +7,8 @@ const internalUtil = require('internal/util');
|
|||||||
const binding = process.binding('util');
|
const binding = process.binding('util');
|
||||||
const spawnSync = require('child_process').spawnSync;
|
const spawnSync = require('child_process').spawnSync;
|
||||||
|
|
||||||
const kArrowMessagePrivateSymbolIndex = binding['arrow_message_private_symbol'];
|
const kArrowMessagePrivateSymbolIndex = binding.arrow_message_private_symbol;
|
||||||
const kDecoratedPrivateSymbolIndex = binding['decorated_private_symbol'];
|
const kDecoratedPrivateSymbolIndex = binding.decorated_private_symbol;
|
||||||
|
|
||||||
const decorateErrorStack = internalUtil.decorateErrorStack;
|
const decorateErrorStack = internalUtil.decorateErrorStack;
|
||||||
|
|
||||||
|
@ -10,4 +10,4 @@ while (files.length < 256)
|
|||||||
files.push(fs.openSync(__filename, 'r'));
|
files.push(fs.openSync(__filename, 'r'));
|
||||||
|
|
||||||
const r = process.memoryUsage();
|
const r = process.memoryUsage();
|
||||||
assert.strictEqual(true, r['rss'] > 0);
|
assert.strictEqual(true, r.rss > 0);
|
||||||
|
@ -30,11 +30,11 @@ const partC = '';
|
|||||||
if (common.isWindows) {
|
if (common.isWindows) {
|
||||||
partA = 'C:\\Users\\Rocko Artischocko\\AppData\\Roaming\\npm';
|
partA = 'C:\\Users\\Rocko Artischocko\\AppData\\Roaming\\npm';
|
||||||
partB = 'C:\\Program Files (x86)\\nodejs\\';
|
partB = 'C:\\Program Files (x86)\\nodejs\\';
|
||||||
process.env['NODE_PATH'] = `${partA};${partB};${partC}`;
|
process.env.NODE_PATH = `${partA};${partB};${partC}`;
|
||||||
} else {
|
} else {
|
||||||
partA = '/usr/test/lib/node_modules';
|
partA = '/usr/test/lib/node_modules';
|
||||||
partB = '/usr/test/lib/node';
|
partB = '/usr/test/lib/node';
|
||||||
process.env['NODE_PATH'] = `${partA}:${partB}:${partC}`;
|
process.env.NODE_PATH = `${partA}:${partB}:${partC}`;
|
||||||
}
|
}
|
||||||
|
|
||||||
mod._initPaths();
|
mod._initPaths();
|
||||||
|
@ -42,14 +42,14 @@ if (process.argv[2] === 'child') {
|
|||||||
|
|
||||||
const env = Object.assign({}, process.env);
|
const env = Object.assign({}, process.env);
|
||||||
// Turn on module debug to aid diagnosing failures.
|
// Turn on module debug to aid diagnosing failures.
|
||||||
env['NODE_DEBUG'] = 'module';
|
env.NODE_DEBUG = 'module';
|
||||||
// Unset NODE_PATH.
|
// Unset NODE_PATH.
|
||||||
delete env['NODE_PATH'];
|
delete env.NODE_PATH;
|
||||||
|
|
||||||
// Test empty global path.
|
// Test empty global path.
|
||||||
const noPkgHomeDir = path.join(tmpdir.path, 'home-no-pkg');
|
const noPkgHomeDir = path.join(tmpdir.path, 'home-no-pkg');
|
||||||
fs.mkdirSync(noPkgHomeDir);
|
fs.mkdirSync(noPkgHomeDir);
|
||||||
env['HOME'] = env['USERPROFILE'] = noPkgHomeDir;
|
env.HOME = env.USERPROFILE = noPkgHomeDir;
|
||||||
assert.throws(
|
assert.throws(
|
||||||
() => {
|
() => {
|
||||||
child_process.execFileSync(testExecPath, [ __filename, 'child' ],
|
child_process.execFileSync(testExecPath, [ __filename, 'child' ],
|
||||||
@ -59,17 +59,17 @@ if (process.argv[2] === 'child') {
|
|||||||
|
|
||||||
// Test module in $HOME/.node_modules.
|
// Test module in $HOME/.node_modules.
|
||||||
const modHomeDir = path.join(testFixturesDir, 'home-pkg-in-node_modules');
|
const modHomeDir = path.join(testFixturesDir, 'home-pkg-in-node_modules');
|
||||||
env['HOME'] = env['USERPROFILE'] = modHomeDir;
|
env.HOME = env.USERPROFILE = modHomeDir;
|
||||||
runTest('$HOME/.node_modules', env);
|
runTest('$HOME/.node_modules', env);
|
||||||
|
|
||||||
// Test module in $HOME/.node_libraries.
|
// Test module in $HOME/.node_libraries.
|
||||||
const libHomeDir = path.join(testFixturesDir, 'home-pkg-in-node_libraries');
|
const libHomeDir = path.join(testFixturesDir, 'home-pkg-in-node_libraries');
|
||||||
env['HOME'] = env['USERPROFILE'] = libHomeDir;
|
env.HOME = env.USERPROFILE = libHomeDir;
|
||||||
runTest('$HOME/.node_libraries', env);
|
runTest('$HOME/.node_libraries', env);
|
||||||
|
|
||||||
// Test module both $HOME/.node_modules and $HOME/.node_libraries.
|
// Test module both $HOME/.node_modules and $HOME/.node_libraries.
|
||||||
const bothHomeDir = path.join(testFixturesDir, 'home-pkg-in-both');
|
const bothHomeDir = path.join(testFixturesDir, 'home-pkg-in-both');
|
||||||
env['HOME'] = env['USERPROFILE'] = bothHomeDir;
|
env.HOME = env.USERPROFILE = bothHomeDir;
|
||||||
runTest('$HOME/.node_modules', env);
|
runTest('$HOME/.node_modules', env);
|
||||||
|
|
||||||
// Test module in $PREFIX/lib/node.
|
// Test module in $PREFIX/lib/node.
|
||||||
@ -82,22 +82,22 @@ if (process.argv[2] === 'child') {
|
|||||||
const pkgPath = path.join(prefixLibNodePath, `${pkgName}.js`);
|
const pkgPath = path.join(prefixLibNodePath, `${pkgName}.js`);
|
||||||
fs.writeFileSync(pkgPath, `exports.string = '${expectedString}';`);
|
fs.writeFileSync(pkgPath, `exports.string = '${expectedString}';`);
|
||||||
|
|
||||||
env['HOME'] = env['USERPROFILE'] = noPkgHomeDir;
|
env.HOME = env.USERPROFILE = noPkgHomeDir;
|
||||||
runTest(expectedString, env);
|
runTest(expectedString, env);
|
||||||
|
|
||||||
// Test module in all global folders.
|
// Test module in all global folders.
|
||||||
env['HOME'] = env['USERPROFILE'] = bothHomeDir;
|
env.HOME = env.USERPROFILE = bothHomeDir;
|
||||||
runTest('$HOME/.node_modules', env);
|
runTest('$HOME/.node_modules', env);
|
||||||
|
|
||||||
// Test module in NODE_PATH is loaded ahead of global folders.
|
// Test module in NODE_PATH is loaded ahead of global folders.
|
||||||
env['HOME'] = env['USERPROFILE'] = bothHomeDir;
|
env.HOME = env.USERPROFILE = bothHomeDir;
|
||||||
env['NODE_PATH'] = path.join(testFixturesDir, 'node_path');
|
env.NODE_PATH = path.join(testFixturesDir, 'node_path');
|
||||||
runTest('$NODE_PATH', env);
|
runTest('$NODE_PATH', env);
|
||||||
|
|
||||||
// Test module in local folder is loaded ahead of global folders.
|
// Test module in local folder is loaded ahead of global folders.
|
||||||
const localDir = path.join(testFixturesDir, 'local-pkg');
|
const localDir = path.join(testFixturesDir, 'local-pkg');
|
||||||
env['HOME'] = env['USERPROFILE'] = bothHomeDir;
|
env.HOME = env.USERPROFILE = bothHomeDir;
|
||||||
env['NODE_PATH'] = path.join(testFixturesDir, 'node_path');
|
env.NODE_PATH = path.join(testFixturesDir, 'node_path');
|
||||||
const child = child_process.execFileSync(testExecPath,
|
const child = child_process.execFileSync(testExecPath,
|
||||||
[ path.join(localDir, 'test.js') ],
|
[ path.join(localDir, 'test.js') ],
|
||||||
{ encoding: 'utf8', env: env });
|
{ encoding: 'utf8', env: env });
|
||||||
|
@ -24,7 +24,7 @@ const cipherlist = {
|
|||||||
};
|
};
|
||||||
|
|
||||||
function test(size, type, name, next) {
|
function test(size, type, name, next) {
|
||||||
const cipher = type ? cipherlist[type] : cipherlist['NOT_PFS'];
|
const cipher = type ? cipherlist[type] : cipherlist.NOT_PFS;
|
||||||
|
|
||||||
if (name) tls.DEFAULT_ECDH_CURVE = name;
|
if (name) tls.DEFAULT_ECDH_CURVE = name;
|
||||||
|
|
||||||
|
@ -285,7 +285,7 @@ assert.strictEqual(
|
|||||||
'{ writeonly: [Setter] }');
|
'{ writeonly: [Setter] }');
|
||||||
|
|
||||||
const value = {};
|
const value = {};
|
||||||
value['a'] = value;
|
value.a = value;
|
||||||
assert.strictEqual(util.inspect(value), '{ a: [Circular] }');
|
assert.strictEqual(util.inspect(value), '{ a: [Circular] }');
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -25,7 +25,7 @@ const assert = require('assert');
|
|||||||
const child = require('child_process');
|
const child = require('child_process');
|
||||||
const fixtures = require('../common/fixtures');
|
const fixtures = require('../common/fixtures');
|
||||||
|
|
||||||
if (process.env['TEST_INIT']) {
|
if (process.env.TEST_INIT) {
|
||||||
return process.stdout.write('Loaded successfully!');
|
return process.stdout.write('Loaded successfully!');
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -27,9 +27,9 @@ function checkScope(session, scopeId) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
function debuggerPausedCallback(session, notification) {
|
function debuggerPausedCallback(session, notification) {
|
||||||
const params = notification['params'];
|
const params = notification.params;
|
||||||
const callFrame = params['callFrames'][0];
|
const callFrame = params.callFrames[0];
|
||||||
const scopeId = callFrame['scopeChain'][0]['object']['objectId'];
|
const scopeId = callFrame.scopeChain[0].object.objectId;
|
||||||
checkScope(session, scopeId);
|
checkScope(session, scopeId);
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -65,11 +65,11 @@ function testSampleDebugSession() {
|
|||||||
scopeCallback = function(error, result) {
|
scopeCallback = function(error, result) {
|
||||||
const i = cur++;
|
const i = cur++;
|
||||||
let v, actual, expected;
|
let v, actual, expected;
|
||||||
for (v of result['result']) {
|
for (v of result.result) {
|
||||||
actual = v['value']['value'];
|
actual = v.value.value;
|
||||||
expected = expects[v['name']][i];
|
expected = expects[v.name][i];
|
||||||
if (actual !== expected) {
|
if (actual !== expected) {
|
||||||
failures.push(`Iteration ${i} variable: ${v['name']} ` +
|
failures.push(`Iteration ${i} variable: ${v.name} ` +
|
||||||
`expected: ${expected} actual: ${actual}`);
|
`expected: ${expected} actual: ${actual}`);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@ -15,12 +15,12 @@ if (!ip)
|
|||||||
|
|
||||||
function checkIpAddress(ip, response) {
|
function checkIpAddress(ip, response) {
|
||||||
const res = response[0];
|
const res = response[0];
|
||||||
const wsUrl = res['webSocketDebuggerUrl'];
|
const wsUrl = res.webSocketDebuggerUrl;
|
||||||
assert.ok(wsUrl);
|
assert.ok(wsUrl);
|
||||||
const match = wsUrl.match(/^ws:\/\/(.*):\d+\/(.*)/);
|
const match = wsUrl.match(/^ws:\/\/(.*):\d+\/(.*)/);
|
||||||
assert.strictEqual(ip, match[1]);
|
assert.strictEqual(ip, match[1]);
|
||||||
assert.strictEqual(res['id'], match[2]);
|
assert.strictEqual(res.id, match[2]);
|
||||||
assert.strictEqual(ip, res['devtoolsFrontendUrl'].match(/.*ws=(.*):\d+/)[1]);
|
assert.strictEqual(ip, res.devtoolsFrontendUrl.match(/.*ws=(.*):\d+/)[1]);
|
||||||
}
|
}
|
||||||
|
|
||||||
function pickIPv4Address() {
|
function pickIPv4Address() {
|
||||||
|
@ -9,10 +9,10 @@ const { NodeInstance } = require('../common/inspector-helper.js');
|
|||||||
|
|
||||||
function checkListResponse(response) {
|
function checkListResponse(response) {
|
||||||
assert.strictEqual(1, response.length);
|
assert.strictEqual(1, response.length);
|
||||||
assert.ok(response[0]['devtoolsFrontendUrl']);
|
assert.ok(response[0].devtoolsFrontendUrl);
|
||||||
assert.ok(
|
assert.ok(
|
||||||
/ws:\/\/127\.0\.0\.1:\d+\/[0-9A-Fa-f]{8}-/
|
/ws:\/\/127\.0\.0\.1:\d+\/[0-9A-Fa-f]{8}-/
|
||||||
.test(response[0]['webSocketDebuggerUrl']));
|
.test(response[0].webSocketDebuggerUrl));
|
||||||
}
|
}
|
||||||
|
|
||||||
function checkVersion(response) {
|
function checkVersion(response) {
|
||||||
@ -32,7 +32,7 @@ function checkBadPath(err) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
function checkException(message) {
|
function checkException(message) {
|
||||||
assert.strictEqual(message['exceptionDetails'], undefined,
|
assert.strictEqual(message.exceptionDetails, undefined,
|
||||||
'An exception occurred during execution');
|
'An exception occurred during execution');
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -45,10 +45,10 @@ function assertNoUrlsWhileConnected(response) {
|
|||||||
function assertScopeValues({ result }, expected) {
|
function assertScopeValues({ result }, expected) {
|
||||||
const unmatched = new Set(Object.keys(expected));
|
const unmatched = new Set(Object.keys(expected));
|
||||||
for (const actual of result) {
|
for (const actual of result) {
|
||||||
const value = expected[actual['name']];
|
const value = expected[actual.name];
|
||||||
if (value) {
|
if (value) {
|
||||||
assert.strictEqual(value, actual['value']['value']);
|
assert.strictEqual(value, actual.value.value);
|
||||||
unmatched.delete(actual['name']);
|
unmatched.delete(actual.name);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
if (unmatched.size)
|
if (unmatched.size)
|
||||||
@ -124,14 +124,14 @@ async function testBreakpoint(session) {
|
|||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
assert.strictEqual(1002, result['value']);
|
assert.strictEqual(1002, result.value);
|
||||||
|
|
||||||
result = (await session.send({
|
result = (await session.send({
|
||||||
'method': 'Runtime.evaluate', 'params': {
|
'method': 'Runtime.evaluate', 'params': {
|
||||||
'expression': '5 * 5'
|
'expression': '5 * 5'
|
||||||
}
|
}
|
||||||
})).result;
|
})).result;
|
||||||
assert.strictEqual(25, result['value']);
|
assert.strictEqual(25, result.value);
|
||||||
}
|
}
|
||||||
|
|
||||||
async function testI18NCharacters(session) {
|
async function testI18NCharacters(session) {
|
||||||
@ -168,7 +168,7 @@ async function testCommandLineAPI(session) {
|
|||||||
}
|
}
|
||||||
});
|
});
|
||||||
checkException(result);
|
checkException(result);
|
||||||
assert.strictEqual(result['result']['value'], true);
|
assert.strictEqual(result.result.value, true);
|
||||||
|
|
||||||
// the global require has the same properties as a normal `require`
|
// the global require has the same properties as a normal `require`
|
||||||
result = await session.send(
|
result = await session.send(
|
||||||
@ -183,7 +183,7 @@ async function testCommandLineAPI(session) {
|
|||||||
}
|
}
|
||||||
});
|
});
|
||||||
checkException(result);
|
checkException(result);
|
||||||
assert.strictEqual(result['result']['value'], true);
|
assert.strictEqual(result.result.value, true);
|
||||||
// `require` twice returns the same value
|
// `require` twice returns the same value
|
||||||
result = await session.send(
|
result = await session.send(
|
||||||
{
|
{
|
||||||
@ -199,7 +199,7 @@ async function testCommandLineAPI(session) {
|
|||||||
}
|
}
|
||||||
});
|
});
|
||||||
checkException(result);
|
checkException(result);
|
||||||
assert.strictEqual(result['result']['value'], true);
|
assert.strictEqual(result.result.value, true);
|
||||||
// after require the module appears in require.cache
|
// after require the module appears in require.cache
|
||||||
result = await session.send(
|
result = await session.send(
|
||||||
{
|
{
|
||||||
@ -211,7 +211,7 @@ async function testCommandLineAPI(session) {
|
|||||||
}
|
}
|
||||||
});
|
});
|
||||||
checkException(result);
|
checkException(result);
|
||||||
assert.deepStrictEqual(JSON.parse(result['result']['value']),
|
assert.deepStrictEqual(JSON.parse(result.result.value),
|
||||||
{ old: 'yes' });
|
{ old: 'yes' });
|
||||||
// remove module from require.cache
|
// remove module from require.cache
|
||||||
result = await session.send(
|
result = await session.send(
|
||||||
@ -222,7 +222,7 @@ async function testCommandLineAPI(session) {
|
|||||||
}
|
}
|
||||||
});
|
});
|
||||||
checkException(result);
|
checkException(result);
|
||||||
assert.strictEqual(result['result']['value'], true);
|
assert.strictEqual(result.result.value, true);
|
||||||
// require again, should get fresh (empty) exports
|
// require again, should get fresh (empty) exports
|
||||||
result = await session.send(
|
result = await session.send(
|
||||||
{
|
{
|
||||||
@ -232,7 +232,7 @@ async function testCommandLineAPI(session) {
|
|||||||
}
|
}
|
||||||
});
|
});
|
||||||
checkException(result);
|
checkException(result);
|
||||||
assert.deepStrictEqual(JSON.parse(result['result']['value']), {});
|
assert.deepStrictEqual(JSON.parse(result.result.value), {});
|
||||||
// require 2nd module, exports an empty object
|
// require 2nd module, exports an empty object
|
||||||
result = await session.send(
|
result = await session.send(
|
||||||
{
|
{
|
||||||
@ -242,7 +242,7 @@ async function testCommandLineAPI(session) {
|
|||||||
}
|
}
|
||||||
});
|
});
|
||||||
checkException(result);
|
checkException(result);
|
||||||
assert.deepStrictEqual(JSON.parse(result['result']['value']), {});
|
assert.deepStrictEqual(JSON.parse(result.result.value), {});
|
||||||
// both modules end up with the same module.parent
|
// both modules end up with the same module.parent
|
||||||
result = await session.send(
|
result = await session.send(
|
||||||
{
|
{
|
||||||
@ -257,7 +257,7 @@ async function testCommandLineAPI(session) {
|
|||||||
}
|
}
|
||||||
});
|
});
|
||||||
checkException(result);
|
checkException(result);
|
||||||
assert.deepStrictEqual(JSON.parse(result['result']['value']), {
|
assert.deepStrictEqual(JSON.parse(result.result.value), {
|
||||||
parentsEqual: true,
|
parentsEqual: true,
|
||||||
parentId: '<inspector console>'
|
parentId: '<inspector console>'
|
||||||
});
|
});
|
||||||
@ -274,7 +274,7 @@ async function testCommandLineAPI(session) {
|
|||||||
}
|
}
|
||||||
});
|
});
|
||||||
checkException(result);
|
checkException(result);
|
||||||
assert.notStrictEqual(result['result']['value'],
|
assert.notStrictEqual(result.result.value,
|
||||||
'<inspector console>');
|
'<inspector console>');
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Loading…
x
Reference in New Issue
Block a user