diff --git a/lib/cluster.js b/lib/cluster.js index 72060c4dd2b..fbb8a75ec09 100644 --- a/lib/cluster.js +++ b/lib/cluster.js @@ -323,7 +323,8 @@ function masterInit() { var handle = handles[key]; if (handle.remove(worker)) delete handles[key]; } - if (Object.keys(handles).length === 0) { + if (Object.keys(cluster.workers).length === 0) { + assert(Object.keys(handles).length === 0, 'Resource leak detected.'); intercom.emit('disconnect'); } }); diff --git a/test/simple/test-cluster-disconnect-idle-worker.js b/test/simple/test-cluster-disconnect-idle-worker.js new file mode 100644 index 00000000000..6f7c877e003 --- /dev/null +++ b/test/simple/test-cluster-disconnect-idle-worker.js @@ -0,0 +1,34 @@ +// Copyright Joyent, Inc. and other Node contributors. +// +// Permission is hereby granted, free of charge, to any person obtaining a +// copy of this software and associated documentation files (the +// "Software"), to deal in the Software without restriction, including +// without limitation the rights to use, copy, modify, merge, publish, +// distribute, sublicense, and/or sell copies of the Software, and to permit +// persons to whom the Software is furnished to do so, subject to the +// following conditions: +// +// The above copyright notice and this permission notice shall be included +// in all copies or substantial portions of the Software. +// +// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS +// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF +// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN +// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, +// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR +// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE +// USE OR OTHER DEALINGS IN THE SOFTWARE. + +var common = require('../common'); +var assert = require('assert'); +var cluster = require('cluster'); + +if (cluster.isMaster) { + cluster.fork(); + cluster.fork(); + cluster.disconnect(common.mustCall(function() { + assert.deepEqual(Object.keys(cluster.workers), []); + })); +} else { + setTimeout(assert.fail, 1e6); +}