buffer: stricter isEncoding
Due to code consolidation in https://github.com/nodejs/node/pull/7207 the isEncoding function got less strict. This commit makes sure isEncoding returns false for empty strings as before the consolidation. PR-URL: https://github.com/nodejs/node/pull/18790 Refs: https://github.com/nodejs/node/pull/7207 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This commit is contained in:
parent
341770fedf
commit
452eed956e
@ -427,7 +427,7 @@ Buffer.compare = function compare(a, b) {
|
||||
|
||||
|
||||
Buffer.isEncoding = function isEncoding(encoding) {
|
||||
return typeof encoding === 'string' &&
|
||||
return typeof encoding === 'string' && encoding.length !== 0 &&
|
||||
normalizeEncoding(encoding) !== undefined;
|
||||
};
|
||||
Buffer[kIsEncodingSymbol] = Buffer.isEncoding;
|
||||
|
Loading…
x
Reference in New Issue
Block a user